[quant][core][gpu][refactor] Refactored auxiliary functions in cudnn Conv.cpp to an utilities file #73957
+146
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Conv.cpp to an utilities file Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
This was referenced Mar 9, 2022
Closed
Closed
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c5b4d27 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. [ghstack-poisoned]
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: [D34995805](https://our.internmc.facebook.com/intern/diff/D34995805) [ghstack-poisoned]
dzdang
added a commit
that referenced
this pull request
Mar 19, 2022
…Conv.cpp to an utilities file Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` ghstack-source-id: 755c1c2 Pull Request resolved: #73957
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Author
|
@jerryzh168 |
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: [D34995805](https://our.internmc.facebook.com/intern/diff/D34995805) [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: [D34995805](https://our.internmc.facebook.com/intern/diff/D34995805) [ghstack-poisoned]
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: [D34995805](https://our.internmc.facebook.com/intern/diff/D34995805) [ghstack-poisoned]
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: [D34995805](https://our.internmc.facebook.com/intern/diff/D34995805) [ghstack-poisoned]
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: [D34995805](https://our.internmc.facebook.com/intern/diff/D34995805) [ghstack-poisoned]
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: [D34995805](https://our.internmc.facebook.com/intern/diff/D34995805) [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…s in cudnn Conv.cpp to an utilities file" Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: [D34995805](https://our.internmc.facebook.com/intern/diff/D34995805) [ghstack-poisoned]
jerryzh168
approved these changes
Mar 23, 2022
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
…Conv.cpp to an utilities file (#73957) Summary: Pull Request resolved: #73957 Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test Plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: D34995805 D34995805 Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 15ea78af2927df583bf4adb596b255412186f902
Contributor
|
Hey @dzdang. |
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
…Conv.cpp to an utilities file (#73957) Summary: Pull Request resolved: #73957 Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test Plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` Differential Revision: D34995805 D34995805 Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 15ea78af2927df583bf4adb596b255412186f902 (cherry picked from commit 6a1260c)
NesrineMHB
pushed a commit
to NesrineMHB/pytorch
that referenced
this pull request
Apr 8, 2022
…Conv.cpp to an utilities file Summary: Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it. Test plan: This file is simply a refactorization and should only affect the cudnn conv operator. We can run the following unit test: ``` python test/test_quantization.py TestQuantizedConv.test_qconv2d_cudnn ``` ghstack-source-id: b498ac0 Pull Request resolved: pytorch/pytorch#73957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Auxiliary functions in Conv.cpp that are applicable to a linear layer operator have been moved to
a utils.h file so that Conv.cpp and the future Linear.cpp file can both use it.
Test plan:
This file is simply a refactorization and should only affect the cudnn
conv operator. We can run the following unit test:
Differential Revision: D34995805