[Quant][core][refactorization] Refactored qlinear_unpack.cpp into an implementation file and higher level call registration and definition file #73956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implementation file and higher level call registration and definition file Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8557ad0 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 9, 2022
Closed
Closed
…pp into an implementation file and higher level call registration and definition file" Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. [ghstack-poisoned]
…pp into an implementation file and higher level call registration and definition file" Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. [ghstack-poisoned]
…pp into an implementation file and higher level call registration and definition file" Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. [ghstack-poisoned]
…pp into an implementation file and higher level call registration and definition file" Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. [ghstack-poisoned]
Contributor
|
we should have |
…pp into an implementation file and higher level call registration and definition file" Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. [ghstack-poisoned]
…pp into an implementation file and higher level call registration and definition file" Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…pp into an implementation file and higher level call registration and definition file" Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. Test plan: ``` python test/test_quantization.py ``` Differential Revision: [D34824249](https://our.internmc.facebook.com/intern/diff/D34824249) [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…pp into an implementation file and higher level call registration and definition file" Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. Test plan: ``` python test/test_quantization.py ``` Differential Revision: [D34824249](https://our.internmc.facebook.com/intern/diff/D34824249) [ghstack-poisoned]
dzdang
added a commit
that referenced
this pull request
Mar 18, 2022
…implementation file and higher level call registration and definition file Summary: This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. Test plan: ``` python test/test_quantization.py ``` ghstack-source-id: f12e590 Pull Request resolved: #73956
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
…implementation file and higher level call registration and definition file (#73956) Summary: Pull Request resolved: #73956 This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. Test Plan: ``` python test/test_quantization.py ``` Imported from OSS Differential Revision: D34824249 D34824249 Reviewed By: ezyang Pulled By: dzdang fbshipit-source-id: 5d33c16dde7f9c7606a26802855094bea4757867
Contributor
|
Hey @dzdang. |
larryliu0820
added a commit
to larryliu0820/pytorch
that referenced
this pull request
Mar 22, 2022
…ytorch#74526) Summary: Pull Request resolved: pytorch#74526 PR pytorch#73956 refactored `qlinear_unpack.cpp` and moved it out from the build system. Hence `TORCH_LIBRARY_IMPL` for `qlinear_unpack` ops are missing from the build. This PR adds it back. Test Plan: CI Differential Revision: D35039381 fbshipit-source-id: e633a7cc8cd85bfccfcb6152c144106d2403b679
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
…74526) Summary: Pull Request resolved: #74526 PR #73956 refactored `qlinear_unpack.cpp` and moved it out from the build system. Hence `TORCH_LIBRARY_IMPL` for `qlinear_unpack` ops are missing from the build. This PR adds it back. Test Plan: CI Reviewed By: dzdang Differential Revision: D35039381 fbshipit-source-id: 86f728f15ec8db25445215c34434a05b11c80e3f
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 22, 2022
…74526) Summary: Pull Request resolved: #74526 PR #73956 refactored `qlinear_unpack.cpp` and moved it out from the build system. Hence `TORCH_LIBRARY_IMPL` for `qlinear_unpack` ops are missing from the build. This PR adds it back. Test Plan: CI Reviewed By: dzdang Differential Revision: D35039381 fbshipit-source-id: 86f728f15ec8db25445215c34434a05b11c80e3f (cherry picked from commit 9cf8c4c)
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
…implementation file and higher level call registration and definition file (#73956) Summary: Pull Request resolved: #73956 This refactorization is analogous to the one done in #73773, but for linear instead of conv. Refer to the summary in that PR for details. Test Plan: ``` python test/test_quantization.py ``` Imported from OSS Differential Revision: D34824249 D34824249 Reviewed By: ezyang Pulled By: dzdang fbshipit-source-id: 5d33c16dde7f9c7606a26802855094bea4757867 (cherry picked from commit b1ab945)
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
…74526) Summary: Pull Request resolved: #74526 PR #73956 refactored `qlinear_unpack.cpp` and moved it out from the build system. Hence `TORCH_LIBRARY_IMPL` for `qlinear_unpack` ops are missing from the build. This PR adds it back. Test Plan: CI Reviewed By: dzdang Differential Revision: D35039381 fbshipit-source-id: 86f728f15ec8db25445215c34434a05b11c80e3f (cherry picked from commit 9cf8c4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
This refactorization is analogous to the one done in #73773, but for linear instead of conv.
Refer to the summary in that PR for details.
Test plan:
Differential Revision: D34824249