[FSDP] Option to summon on rank 0 only #73903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to summon full parameter on rank0_only. Note that as documented, when using this flag, writes are only guaranteed to persist for rank 0. Differential Revision: [D34706449](https://our.internmc.facebook.com/intern/diff/D34706449/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 3943ef5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
Add an option to summon full parameter on rank0_only. Note that as documented, when using this flag, writes are only guaranteed to persist for rank 0. Differential Revision: [D34706449](https://our.internmc.facebook.com/intern/diff/D34706449/) [ghstack-poisoned]
fegin
reviewed
Mar 9, 2022
Contributor
fegin
left a comment
fegin
left a comment
There was a problem hiding this comment.
LGTM. Just one comment about how the combination of the arguments summon_full_param() are handled.
| materialized on only global rank 0. This means that within the | ||
| context, only rank 0 will have full parameters and the other | ||
| ranks will have sharded parameters. This further means that for | ||
| non-zero ranks, the `writeback` argument is ignored and |
Contributor
There was a problem hiding this comment.
Instead of implicitly ignoring writeback, should we ask users to explicitly writeback to False?
Add an option to summon full parameter on rank0_only. Note that as documented, when using this flag, writes are only guaranteed to persist for rank 0. Differential Revision: [D34706449](https://our.internmc.facebook.com/intern/diff/D34706449/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Mar 9, 2022
Pull Request resolved: #73903 Add an option to summon full parameter on rank0_only. Note that as documented, when using this flag, writes are only guaranteed to persist for rank 0. ghstack-source-id: 150949236 Differential Revision: [D34706449](https://our.internmc.facebook.com/intern/diff/D34706449/)
Add an option to summon full parameter on rank0_only. writeback=True is not supported. Differential Revision: [D34706449](https://our.internmc.facebook.com/intern/diff/D34706449/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
Summary: Pull Request resolved: #73903 Add an option to summon full parameter on rank0_only. Note that as documented, when using this flag, writes are only guaranteed to persist for rank 0. ghstack-source-id: 151311233 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D34706449 fbshipit-source-id: 034d76cdae6916a225bd6fcee092db48359f8a0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add an option to summon full parameter on rank0_only. writeback=True is not supported.
Differential Revision: D34706449