EmbeddingBag to handle empty bags in all modes #7389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsimig
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Member
|
cc @cpuhrsch |
Contributor
|
This is a good idea. We really would need that GPU implementation though. Are you down for the GPU changes (I can make the GPU implementation changes if necessarily) ? |
colesbury
reviewed
May 8, 2018
Member
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
@adamlerer, you already reviewed this, right?
Author
|
@colesbury the changes for max pooling have not been reviewed as max pooling was not synced at the time. |
Author
|
@lalaland I'm not familiar with how the GPU implementation works and I don't think I'll have time for it, so if you could help out that'd be fantastic! |
colesbury
approved these changes
May 10, 2018
Member
|
@pytorchbot retest this please |
onnxbot
added a commit
to onnxbot/onnx-fb-universe
that referenced
this pull request
May 10, 2018
Merged
weiyangfb
pushed a commit
to weiyangfb/pytorch
that referenced
this pull request
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously EmbeddingBag was not able to deal with empty bags (that is, two consecutive elements in the offsets tensor). With this change, EmbeddingBag will return an all-zero vector as the embedding if it comes across an empty bag, regardless of the mode.