[pyper] to + lengths_to_offsets #73879
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1ce8e40 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34696255 |
facebook-github-bot
added
the
oncall: jit
Summary: Pull Request resolved: pytorch#73879 Fuse the following pattern: ``` %1994 : Tensor = aten::to(%getattr_78.1, %188, %189, %189) # <eval_with_key>.50:11:0 %1995 : Tensor = fb::lengths_to_offsets(%1994, %190) # /mnt/xarfuse/uid-1994 ``` This pattern is applied after all the applicable clip_ranges+gather_ranges patterns Additional context in https://fb.quip.com/DSCbAozMBwUi Test Plan: > ./caffe2/caffe2/fb/predictor/scripts/run_disagg_model_benchmarks.sh 321004917 27 /data/users/ansha/tmp/ads_tail sr_only ~0.007ms overall reduction in tail model runtime (321004917_27 oemae_long_attr_win_2d_7d_aux_model) **Local (25 fused nodes)** Before: 2.04ms/iter 0.0112739 ms. 0.543996%. fb::lengths_to_offsets (31 nodes, out variant) 0.00805597 ms. 0.388722%. static_runtime::to_maybe_copy_out (30 nodes, out variant) After: 1.96256ms/iter 0.0100853 ms. 0.498655%. fb::to_lengths_to_offsets (25 nodes, out variant) 0.00328385 ms. 0.157536%. fb::lengths_to_offsets (6 nodes, out variant) 0.00239722 ms. 0.115002%. static_runtime::to_maybe_copy_out (5 nodes, out variant) **Local_RO (43 fused nodes)** Before: 0.11427 0.0110696 ms. 9.42255%. fb::lengths_to_offsets (43 nodes, out variant) 0.00638323 ms. 5.43349%. static_runtime::to_maybe_copy_out (43 nodes, out variant) After: 0.112098ms/iter 0.014206 ms. 12.6795%. fb::to_lengths_to_offsets (43 nodes, out variant) **Remote_RO (17 fused nodes)** Before: 0.24 0.0534883 ms. 23.0586%. static_runtime::to_maybe_copy_out (136 nodes, out variant) 0.00216992 ms. 0.935446%. fb::lengths_to_offsets (17 nodes, out variant) After: 0.240225 0.0525392 ms. 23.2864%. static_runtime::to_maybe_copy_out (119 nodes, out variant) 0.00265347 ms. 1.17607%. fb::to_lengths_to_offsets (17 nodes, out variant) Remote_Other (3 fused nodes) Not much affect Differential Revision: D34696255 fbshipit-source-id: d9b07a9f7f3b3ec83584305295de5cdad538abc9
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34696255 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
Summary: Pull Request resolved: #73879 Fuse the following pattern: ``` %1994 : Tensor = aten::to(%getattr_78.1, %188, %189, %189) # <eval_with_key>.50:11:0 %1995 : Tensor = fb::lengths_to_offsets(%1994, %190) # /mnt/xarfuse/uid-1994 ``` This pattern is applied after all the applicable clip_ranges+gather_ranges patterns Additional context in https://fb.quip.com/DSCbAozMBwUi Test Plan: > ./caffe2/caffe2/fb/predictor/scripts/run_disagg_model_benchmarks.sh 321004917 27 /data/users/ansha/tmp/ads_tail sr_only ~0.007ms overall reduction in tail model runtime (321004917_27 oemae_long_attr_win_2d_7d_aux_model) **Local (25 fused nodes)** Before: 2.04ms/iter 0.0112739 ms. 0.543996%. fb::lengths_to_offsets (31 nodes, out variant) 0.00805597 ms. 0.388722%. static_runtime::to_maybe_copy_out (30 nodes, out variant) After: 1.96256ms/iter 0.0100853 ms. 0.498655%. fb::to_lengths_to_offsets (25 nodes, out variant) 0.00328385 ms. 0.157536%. fb::lengths_to_offsets (6 nodes, out variant) 0.00239722 ms. 0.115002%. static_runtime::to_maybe_copy_out (5 nodes, out variant) **Local_RO (43 fused nodes)** Before: 0.11427 0.0110696 ms. 9.42255%. fb::lengths_to_offsets (43 nodes, out variant) 0.00638323 ms. 5.43349%. static_runtime::to_maybe_copy_out (43 nodes, out variant) After: 0.112098ms/iter 0.014206 ms. 12.6795%. fb::to_lengths_to_offsets (43 nodes, out variant) **Remote_RO (17 fused nodes)** Before: 0.24 0.0534883 ms. 23.0586%. static_runtime::to_maybe_copy_out (136 nodes, out variant) 0.00216992 ms. 0.935446%. fb::lengths_to_offsets (17 nodes, out variant) After: 0.240225 0.0525392 ms. 23.2864%. static_runtime::to_maybe_copy_out (119 nodes, out variant) 0.00265347 ms. 1.17607%. fb::to_lengths_to_offsets (17 nodes, out variant) Remote_Other (3 fused nodes) Not much affect Reviewed By: mikeiovine Differential Revision: D34696255 fbshipit-source-id: a0dc4a8ff8f25a825f6dc371ec5e4b3b09740c29
Contributor
|
Hey @ajyu. |
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: #73879 Fuse the following pattern: ``` %1994 : Tensor = aten::to(%getattr_78.1, %188, %189, %189) # <eval_with_key>.50:11:0 %1995 : Tensor = fb::lengths_to_offsets(%1994, %190) # /mnt/xarfuse/uid-1994 ``` This pattern is applied after all the applicable clip_ranges+gather_ranges patterns Additional context in https://fb.quip.com/DSCbAozMBwUi Test Plan: > ./caffe2/caffe2/fb/predictor/scripts/run_disagg_model_benchmarks.sh 321004917 27 /data/users/ansha/tmp/ads_tail sr_only ~0.007ms overall reduction in tail model runtime (321004917_27 oemae_long_attr_win_2d_7d_aux_model) **Local (25 fused nodes)** Before: 2.04ms/iter 0.0112739 ms. 0.543996%. fb::lengths_to_offsets (31 nodes, out variant) 0.00805597 ms. 0.388722%. static_runtime::to_maybe_copy_out (30 nodes, out variant) After: 1.96256ms/iter 0.0100853 ms. 0.498655%. fb::to_lengths_to_offsets (25 nodes, out variant) 0.00328385 ms. 0.157536%. fb::lengths_to_offsets (6 nodes, out variant) 0.00239722 ms. 0.115002%. static_runtime::to_maybe_copy_out (5 nodes, out variant) **Local_RO (43 fused nodes)** Before: 0.11427 0.0110696 ms. 9.42255%. fb::lengths_to_offsets (43 nodes, out variant) 0.00638323 ms. 5.43349%. static_runtime::to_maybe_copy_out (43 nodes, out variant) After: 0.112098ms/iter 0.014206 ms. 12.6795%. fb::to_lengths_to_offsets (43 nodes, out variant) **Remote_RO (17 fused nodes)** Before: 0.24 0.0534883 ms. 23.0586%. static_runtime::to_maybe_copy_out (136 nodes, out variant) 0.00216992 ms. 0.935446%. fb::lengths_to_offsets (17 nodes, out variant) After: 0.240225 0.0525392 ms. 23.2864%. static_runtime::to_maybe_copy_out (119 nodes, out variant) 0.00265347 ms. 1.17607%. fb::to_lengths_to_offsets (17 nodes, out variant) Remote_Other (3 fused nodes) Not much affect Reviewed By: mikeiovine Differential Revision: D34696255 fbshipit-source-id: a0dc4a8ff8f25a825f6dc371ec5e4b3b09740c29 (cherry picked from commit a49b482)
Contributor
|
This pull request has been reverted by 91a72e9. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Contributor
|
This pull request has been reverted by 91a72e9. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fuse the following pattern:
This pattern is applied after all the applicable clip_ranges+gather_ranges patterns
Additional context in https://fb.quip.com/DSCbAozMBwUi
Test Plan:
~0.007ms overall reduction in tail model runtime
(321004917_27 oemae_long_attr_win_2d_7d_aux_model)
Local (25 fused nodes)
Before: 2.04ms/iter
0.0112739 ms. 0.543996%. fb::lengths_to_offsets (31 nodes, out variant)
0.00805597 ms. 0.388722%. static_runtime::to_maybe_copy_out (30 nodes, out variant)
After: 1.96256ms/iter
0.0100853 ms. 0.498655%. fb::to_lengths_to_offsets (25 nodes, out variant)
0.00328385 ms. 0.157536%. fb::lengths_to_offsets (6 nodes, out variant)
0.00239722 ms. 0.115002%. static_runtime::to_maybe_copy_out (5 nodes, out variant)
Local_RO (43 fused nodes)
Before: 0.11427
0.0110696 ms. 9.42255%. fb::lengths_to_offsets (43 nodes, out variant)
0.00638323 ms. 5.43349%. static_runtime::to_maybe_copy_out (43 nodes, out variant)
After: 0.112098ms/iter
0.014206 ms. 12.6795%. fb::to_lengths_to_offsets (43 nodes, out variant)
Remote_RO (17 fused nodes)
Before: 0.24
0.0534883 ms. 23.0586%. static_runtime::to_maybe_copy_out (136 nodes, out variant)
0.00216992 ms. 0.935446%. fb::lengths_to_offsets (17 nodes, out variant)
After: 0.240225
0.0525392 ms. 23.2864%. static_runtime::to_maybe_copy_out (119 nodes, out variant)
0.00265347 ms. 1.17607%. fb::to_lengths_to_offsets (17 nodes, out variant)
Remote_Other (3 fused nodes)
Not much affect
Differential Revision: D34696255