Get rid of TorchScript sparse tensor is experimental warning. #73874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These get triggered when you are doing normal stuff with sparse tensors and `__torch_dispatch__`, but it all works fine. No need to warn. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8bc6ec6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
…ng." These get triggered when you are doing normal stuff with sparse tensors and `__torch_dispatch__`, but it all works fine. No need to warn. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
Contributor
Author
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
bdhirsh
approved these changes
Mar 8, 2022
Contributor
bdhirsh
left a comment
bdhirsh
left a comment
There was a problem hiding this comment.
lgtm (looks like those warnings were added > 2 years ago)
Contributor
Author
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: #73874 These get triggered when you are doing normal stuff with sparse tensors and `__torch_dispatch__`, but it all works fine. No need to warn. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bdhirsh Differential Revision: D34707395 Pulled By: ezyang fbshipit-source-id: 3492c03abb1df1e925af3855dbf772784405d8c1
Contributor
|
Hey @ezyang. |
ezyang
added
release notes: jit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These get triggered when you are doing normal stuff with sparse
tensors and
__torch_dispatch__, but it all works fine. No needto warn.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D34707395