Fix segfault while real and imaginary attributes are set to a number #73867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 60c7724 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
anjali411
added
release notes: complex
| auto& self_ = THPVariable_Unpack(self); | ||
| auto& real_ = THPVariable_Unpack(real); | ||
| auto self_real = at::real(self_); | ||
| auto real_ = valueToTensor(self_real.options(), real, self_real.device()); |
Contributor
There was a problem hiding this comment.
will this materialize the value tensor to the shape or real?
Contributor
Author
There was a problem hiding this comment.
no it just creates a zero dimensional tensor
…o a number" Fixes #72947 [ghstack-poisoned]
Contributor
Author
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…o a number" Fixes #72947 Differential Revision: [D34695956](https://our.internmc.facebook.com/intern/diff/D34695956) [ghstack-poisoned]
ezyang
approved these changes
Mar 8, 2022
…o a number" Fixes #72947 Differential Revision: [D34695956](https://our.internmc.facebook.com/intern/diff/D34695956) [ghstack-poisoned]
Contributor
Author
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
…(#73867) Summary: Pull Request resolved: pytorch/pytorch#73867 Fixes pytorch/pytorch#72947 Test Plan: Imported from OSS Reviewed By: davidberard98 Differential Revision: D34695956 Pulled By: anjali411 fbshipit-source-id: 2f3eda272a5214335eae506bd387ce8da4d81b8c (cherry picked from commit fdb07354cac22c30aa047e65fbac9840608db811)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
…(#73867) Summary: Pull Request resolved: pytorch/pytorch#73867 Fixes pytorch/pytorch#72947 Test Plan: Imported from OSS Reviewed By: davidberard98 Differential Revision: D34695956 Pulled By: anjali411 fbshipit-source-id: 2f3eda272a5214335eae506bd387ce8da4d81b8c (cherry picked from commit fdb07354cac22c30aa047e65fbac9840608db811)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #72947
Differential Revision: D34695956