FX graph module - prevent infinite recursion #73866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: super(type(self), self) in wrapped_call leads to infinite rescursion for Fx graph module. Test Plan: Tests added in #62436 Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8d50360 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Summary: super(type(self), self) in wrapped_call leads to infinite rescursion for Fx graph module. Test Plan: Tests added in #62436 Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Mar 8, 2022
Summary: super(type(self), self) in wrapped_call leads to infinite rescursion for Fx graph module. This happens when we call _stateless.functional_call on a fx module. https://github.com/pytorch/pytorch/blob/master/torch%2Fnn%2Futils%2F_stateless.py Test Plan: New tests and original tests added in #62436 Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c9d5360 Pull Request resolved: #73866
jansel
approved these changes
Mar 8, 2022
Contributor
Author
|
@anijain2305 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: #73866 super(type(self), self) in wrapped_call leads to infinite recursion for subclass of Fx graph module. This happens when we call _stateless.functional_call on a fx module. https://github.com/pytorch/pytorch/blob/master/torch%2Fnn%2Futils%2F_stateless.py Test Plan: Tests added in #62436 Imported from OSS Reviewed By: jansel Differential Revision: D34737828 fbshipit-source-id: 871b897e1210173ccc83fe34d53fc41af00a39ee
Contributor
|
Hey @anijain2305. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#73866 super(type(self), self) in wrapped_call leads to infinite recursion for subclass of Fx graph module. This happens when we call _stateless.functional_call on a fx module. https://github.com/pytorch/pytorch/blob/master/torch%2Fnn%2Futils%2F_stateless.py Test Plan: Tests added in pytorch/pytorch#62436 Imported from OSS Reviewed By: jansel Differential Revision: D34737828 fbshipit-source-id: 871b897e1210173ccc83fe34d53fc41af00a39ee (cherry picked from commit 3d0c5fc71503fa2782b497a9d39ce26288fd219b)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#73866 super(type(self), self) in wrapped_call leads to infinite recursion for subclass of Fx graph module. This happens when we call _stateless.functional_call on a fx module. https://github.com/pytorch/pytorch/blob/master/torch%2Fnn%2Futils%2F_stateless.py Test Plan: Tests added in pytorch/pytorch#62436 Imported from OSS Reviewed By: jansel Differential Revision: D34737828 fbshipit-source-id: 871b897e1210173ccc83fe34d53fc41af00a39ee (cherry picked from commit 3d0c5fc71503fa2782b497a9d39ce26288fd219b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: super(type(self), self) in wrapped_call leads to infinite recursion for subclass of Fx graph module. This happens when we call _stateless.functional_call on a fx module. https://github.com/pytorch/pytorch/blob/master/torch%2Fnn%2Futils%2F_stateless.py
Test Plan: Tests added in #62436
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D34737828