Report the names of unsupported operators in flatbuffer_loader.cpp #73865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
- Report the names of unsupported operators in `flatbuffer_loader.cpp`:
```
TORCH_CHECK(
unsupported_op_names.empty(),
"Unsupported ops: ",
c10::Join(", ", unsupported_op_names));
```
- Use `TORCH_CHECK` instead of `AT_ASSERT` because `AT_ASSERT` is deprecated (see https://www.internalfb.com/code/fbsource/[9fbf30fa6401f8b341c3100c90f9d929a8ad7f9b]/fbcode/caffe2/c10/util/Exception.h?lines=585)
Test Plan: CI
Differential Revision: D34635838
fbshipit-source-id: 3d575c0482773b2a66a965251ff67e3ac37065f9
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c6ee48a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: jit
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34635838 |
qihqi
approved these changes
Mar 9, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 10, 2022
…73865) Summary: Pull Request resolved: #73865 - Report the names of unsupported operators in `flatbuffer_loader.cpp`: ``` TORCH_CHECK( unsupported_op_names.empty(), "Unsupported ops: ", c10::Join(", ", unsupported_op_names)); ``` - Use `TORCH_CHECK` instead of `AT_ASSERT` because `AT_ASSERT` is deprecated (see https://www.internalfb.com/code/fbsource/[9fbf30fa6401f8b341c3100c90f9d929a8ad7f9b]/fbcode/caffe2/c10/util/Exception.h?lines=585) Test Plan: CI Reviewed By: qihqi Differential Revision: D34635838 fbshipit-source-id: e95d3369d66c18d312fe56c1f44606fe86504947
Contributor
|
Hey @poweic. |
qihqi
added
release notes: mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
flatbuffer_loader.cpp:TORCH_CHECKinstead ofAT_ASSERTbecauseAT_ASSERTis deprecated (see https://www.internalfb.com/code/fbsource/[9fbf30fa6401f8b341c3100c90f9d929a8ad7f9b]/fbcode/caffe2/c10/util/Exception.h?lines=585)Test Plan: CI
Differential Revision: D34635838