[pytorch][PR][Kineto] Manual Submodule Update #73858
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ba529c5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34689078 |
Member
Author
|
This is opened since the last change was reverted, and failed certain builds. #73090 This patch will enable those builds and try to fix them. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34689078 |
aaronenyeshi
added a commit
to aaronenyeshi/pytorch
that referenced
this pull request
Mar 7, 2022
Summary: Pull Request resolved: pytorch#73858 The newer version of Kineto has changes to handle generic activities (such as RocTracer generic activities), so we can remove the older USE_KINETO_UPDATED macro and implementation of flow.linkedActivity. This patch should bring Kineto back in sync on PyTorch CI. Test Plan: PyTorch OSS CI needs to pass for this submodule update of third_party/kineto repo. With ciflow/cuda enabled. Differential Revision: D34689078 Pulled By: aaronenyeshi fbshipit-source-id: a7fa61b6c5b1fc7d48f80da7868671be6aff5690
aaronenyeshi
force-pushed
the
export-D34689078
branch
from
154aab1 to
f2b8543
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34689078 |
aaronenyeshi
force-pushed
the
export-D34689078
branch
from
f2b8543 to
8971009
Compare
aaronenyeshi
added a commit
to aaronenyeshi/pytorch
that referenced
this pull request
Mar 8, 2022
Summary: Pull Request resolved: pytorch#73858 The newer version of Kineto has changes to handle generic activities (such as RocTracer generic activities), so we can remove the older USE_KINETO_UPDATED macro and implementation of flow.linkedActivity. This patch should bring Kineto back in sync on PyTorch CI. Test Plan: PyTorch OSS CI needs to pass for this submodule update of third_party/kineto repo. With ciflow/cuda enabled. Differential Revision: D34689078 Pulled By: aaronenyeshi fbshipit-source-id: 6f8e793aa26cb82174f2610af1674263e8ac1c08
Member
Author
|
Hi @malfet, would you please help me double-check that my tags are correct for the CI to run all Kineto dependent tests/jobs? |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34689078 |
aaronenyeshi
force-pushed
the
export-D34689078
branch
from
8971009 to
915405d
Compare
aaronenyeshi
added a commit
to aaronenyeshi/pytorch
that referenced
this pull request
Mar 11, 2022
Summary: Pull Request resolved: pytorch#73858 The newer version of Kineto has changes to handle generic activities (such as RocTracer generic activities), so we can remove the older USE_KINETO_UPDATED macro and implementation of flow.linkedActivity. This patch should bring Kineto back in sync on PyTorch CI. Test Plan: PyTorch OSS CI needs to pass for this submodule update of third_party/kineto repo. With ciflow/cuda enabled. Reviewed By: chaekit Differential Revision: D34689078 Pulled By: aaronenyeshi fbshipit-source-id: 4588ead174ab23ecd95facc3a50702b069d423c3
Member
Author
|
@pytorchbot merge this |
Collaborator
|
Merge failed due to PR 73858 does not match merge rules |
Summary: Pull Request resolved: pytorch#73858 The newer version of Kineto has changes to handle generic activities (such as RocTracer generic activities), so we can remove the older USE_KINETO_UPDATED macro and implementation of flow.linkedActivity. This patch should bring Kineto back in sync on PyTorch CI. Test Plan: PyTorch OSS CI needs to pass for this submodule update of third_party/kineto repo. With ciflow/cuda enabled. Reviewed By: chaekit Differential Revision: D34689078 Pulled By: aaronenyeshi fbshipit-source-id: 87749f7c0e3a5bd585525e90196fd661500e3746
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34689078 |
aaronenyeshi
force-pushed
the
export-D34689078
branch
from
915405d to
ba529c5
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
Summary: Pull Request resolved: #73858 The newer version of Kineto has changes to handle generic activities (such as RocTracer generic activities), so we can remove the older USE_KINETO_UPDATED macro and implementation of flow.linkedActivity. This patch should bring Kineto back in sync on PyTorch CI. Test Plan: PyTorch OSS CI needs to pass for this submodule update of third_party/kineto repo. With ciflow/cuda enabled. Reviewed By: chaekit Differential Revision: D34689078 Pulled By: aaronenyeshi fbshipit-source-id: 305431cbce95ecd57c23b0485e4bb921ea2c7c0a
Contributor
|
Hey @aaronenyeshi. |
aaronenyeshi
added
release notes: profiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The newer version of Kineto has changes to handle generic activities (such as RocTracer generic activities), so we can remove the older USE_KINETO_UPDATED macro and implementation of flow.linkedActivity.
This patch should bring Kineto back in sync on PyTorch CI.
Test Plan: PyTorch OSS CI needs to pass for this submodule update of third_party/kineto repo. With ciflow/cuda enabled.
Differential Revision: D34689078
Pulled By: aaronenyeshi