Relax dtype restrictions on torch.Tensor #73850
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, torch.Tensor was treated as if it were torch.FloatTensor (where Float is whatever the default dtype was). This is not good behavior for tensor subclasses, which inherit from torch.Tensor and will want to super() call into it and will only notice later that only float works as a dtype. So in this PR I relax the behavior for this case to make the torch.Tensor constructor more useful for subclasses. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1ec06f7 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Previously, torch.Tensor was treated as if it were torch.FloatTensor (where Float is whatever the default dtype was). This is not good behavior for tensor subclasses, which inherit from torch.Tensor and will want to super() call into it and will only notice later that only float works as a dtype. So in this PR I relax the behavior for this case to make the torch.Tensor constructor more useful for subclasses. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Mar 7, 2022
Previously, torch.Tensor was treated as if it were torch.FloatTensor (where Float is whatever the default dtype was). This is not good behavior for tensor subclasses, which inherit from torch.Tensor and will want to super() call into it and will only notice later that only float works as a dtype. So in this PR I relax the behavior for this case to make the torch.Tensor constructor more useful for subclasses. Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 656b68b Pull Request resolved: #73850
Previously, torch.Tensor was treated as if it were torch.FloatTensor (where Float is whatever the default dtype was). This is not good behavior for tensor subclasses, which inherit from torch.Tensor and will want to super() call into it and will only notice later that only float works as a dtype. So in this PR I relax the behavior for this case to make the torch.Tensor constructor more useful for subclasses. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
Contributor
Author
|
test added |
Contributor
Author
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Author
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: #73850 Previously, torch.Tensor was treated as if it were torch.FloatTensor (where Float is whatever the default dtype was). This is not good behavior for tensor subclasses, which inherit from torch.Tensor and will want to super() call into it and will only notice later that only float works as a dtype. So in this PR I relax the behavior for this case to make the torch.Tensor constructor more useful for subclasses. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D34707396 Pulled By: ezyang fbshipit-source-id: a995d601007b6fcd0317d89f66ca7e08c4d6053e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, torch.Tensor was treated as if it were torch.FloatTensor
(where Float is whatever the default dtype was). This is not good
behavior for tensor subclasses, which inherit from torch.Tensor and
will want to super() call into it and will only notice later that
only float works as a dtype. So in this PR I relax the behavior
for this case to make the torch.Tensor constructor more useful for
subclasses.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D34707396