[pytorch] flatten_indices function should use vector::resize instead of reserve #73831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of reserve Summary: stderr: test_jagged_2d_to_dense_truncation (deeplearning.fbgemm.fbgemm_gpu.test.sparse_ops_test.SparseOpsTest) ... third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:1045: std::vector::reference std::vector<long>::operator[](std::vector::size_type) [_Tp = long, _Alloc = std::allocator<long>]: Assertion '__n < this->size()' failed. After some digging, we found the issue is not caused by fbgemm. It is caused by the underlying coo_sparse_tensor.to_dense() function, which fails for all sparse tensors on platform010, because of the misuse of vector::reserve in flatten_indices function. Test Plan: buck test mode/dev -c fbcode.platform=platform010 //deeplearning/fbgemm/fbgemm_gpu:sparse_ops_test -- test_jagged_2d_to_dense_truncation Reviewed By: jspark1105 Differential Revision: D34665804 fbshipit-source-id: 2adad5496bdd64fb21607118b82e574fc156f59e
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 9dd1cf0 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34665804 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
…of reserve (#73831) Summary: Pull Request resolved: #73831 stderr: test_jagged_2d_to_dense_truncation (deeplearning.fbgemm.fbgemm_gpu.test.sparse_ops_test.SparseOpsTest) ... third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:1045: std::vector::reference std::vector<long>::operator[](std::vector::size_type) [_Tp = long, _Alloc = std::allocator<long>]: Assertion '__n < this->size()' failed. After some digging, we found the issue is not caused by fbgemm. It is caused by the underlying coo_sparse_tensor.to_dense() function, which fails for all sparse tensors on platform010, because of the misuse of vector::reserve in flatten_indices function. Test Plan: buck test mode/dev -c fbcode.platform=platform010 //deeplearning/fbgemm/fbgemm_gpu:sparse_ops_test -- test_jagged_2d_to_dense_truncation Reviewed By: jspark1105 Differential Revision: D34665804 fbshipit-source-id: 685cfd516fded224cfdb44b5a5f18c2d8e0ec644
Contributor
|
Hey @jiyuanzFB. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
…of reserve (#73831) Summary: Pull Request resolved: pytorch/pytorch#73831 stderr: test_jagged_2d_to_dense_truncation (deeplearning.fbgemm.fbgemm_gpu.test.sparse_ops_test.SparseOpsTest) ... third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:1045: std::vector::reference std::vector<long>::operator[](std::vector::size_type) [_Tp = long, _Alloc = std::allocator<long>]: Assertion '__n < this->size()' failed. After some digging, we found the issue is not caused by fbgemm. It is caused by the underlying coo_sparse_tensor.to_dense() function, which fails for all sparse tensors on platform010, because of the misuse of vector::reserve in flatten_indices function. Test Plan: buck test mode/dev -c fbcode.platform=platform010 //deeplearning/fbgemm/fbgemm_gpu:sparse_ops_test -- test_jagged_2d_to_dense_truncation Reviewed By: jspark1105 Differential Revision: D34665804 fbshipit-source-id: 685cfd516fded224cfdb44b5a5f18c2d8e0ec644 (cherry picked from commit 0c33c3a8499d58149afa7b54a333e5b28803210b)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
…of reserve (#73831) Summary: Pull Request resolved: pytorch/pytorch#73831 stderr: test_jagged_2d_to_dense_truncation (deeplearning.fbgemm.fbgemm_gpu.test.sparse_ops_test.SparseOpsTest) ... third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:1045: std::vector::reference std::vector<long>::operator[](std::vector::size_type) [_Tp = long, _Alloc = std::allocator<long>]: Assertion '__n < this->size()' failed. After some digging, we found the issue is not caused by fbgemm. It is caused by the underlying coo_sparse_tensor.to_dense() function, which fails for all sparse tensors on platform010, because of the misuse of vector::reserve in flatten_indices function. Test Plan: buck test mode/dev -c fbcode.platform=platform010 //deeplearning/fbgemm/fbgemm_gpu:sparse_ops_test -- test_jagged_2d_to_dense_truncation Reviewed By: jspark1105 Differential Revision: D34665804 fbshipit-source-id: 685cfd516fded224cfdb44b5a5f18c2d8e0ec644 (cherry picked from commit 0c33c3a8499d58149afa7b54a333e5b28803210b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
stderr:
test_jagged_2d_to_dense_truncation (deeplearning.fbgemm.fbgemm_gpu.test.sparse_ops_test.SparseOpsTest) ... third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:1045: std::vector::reference std::vector::operator [_Tp = long, _Alloc = std::allocator]: Assertion '__n < this->size()' failed.
After some digging, we found the issue is not caused by fbgemm. It is caused by the underlying coo_sparse_tensor.to_dense() function, which fails for all sparse tensors on platform010, because of the misuse of vector::reserve in flatten_indices function.
Test Plan: buck test mode/dev -c fbcode.platform=platform010 //deeplearning/fbgemm/fbgemm_gpu:sparse_ops_test -- test_jagged_2d_to_dense_truncation
Reviewed By: jspark1105
Differential Revision: D34665804