make sharding strategy configurable and support zero2 algorithm #73819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads Differential Revision: [D34662583](https://our.internmc.facebook.com/intern/diff/D34662583/) [ghstack-poisoned]
zhaojuanmao
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87 and
rohan-varma
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 012f852 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
zhaojuanmao
added a commit
that referenced
this pull request
Mar 5, 2022
adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads Differential Revision: [D34662583](https://our.internmc.facebook.com/intern/diff/D34662583/) ghstack-source-id: 150613344 Pull Request resolved: #73819
rohan-varma
reviewed
Mar 8, 2022
…2 algorithm" adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads Differential Revision: [D34662583](https://our.internmc.facebook.com/intern/diff/D34662583/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Mar 9, 2022
Pull Request resolved: #73819 adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads ghstack-source-id: 150893171 Differential Revision: [D34662583](https://our.internmc.facebook.com/intern/diff/D34662583/)
zhaojuanmao
changed the title
awgu
reviewed
Mar 9, 2022
rohan-varma
approved these changes
Mar 10, 2022
Contributor
rohan-varma
left a comment
rohan-varma
left a comment
There was a problem hiding this comment.
Looks great, excited to have users try out Zero-2!
Stamping to unblock, but some tests seem to be failing.
…rithm" adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads Differential Revision: [D34662583](https://our.internmc.facebook.com/intern/diff/D34662583/) [ghstack-poisoned]
…rithm" adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads Differential Revision: [D34662583](https://our.internmc.facebook.com/intern/diff/D34662583/) [ghstack-poisoned]
…rithm" adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads Differential Revision: [D34662583](https://our.internmc.facebook.com/intern/diff/D34662583/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Mar 15, 2022
Pull Request resolved: #73819 adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads ghstack-source-id: 151454460 Differential Revision: [D34662583](https://our.internmc.facebook.com/intern/diff/D34662583/)
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #73819 adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads ghstack-source-id: 151454460 Test Plan: unit tests Reviewed By: rohan-varma Differential Revision: D34662583 fbshipit-source-id: 14c6e0c0054692ecd76512c025d60deb4964ec5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
adding a new sharding_strategy config in FSDP API to support different data parallel algorithm. also add support for zero2 algorithm, which will only shard optimizer states and grads
Differential Revision: D34662583