[PyTorch] Make TensorImpl::sizes() customizable and disable it for NestedTensorImpl #73817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stedTensorImpl NestedTensorImpl doesn't have sizes(). Silently getting wrong results back from it is not conducive to efficient software development. Make it throw while allowing sizes() to be inlined in the common case anyway, just like is_contiguous(). Thanks @ezyang for the reminder that we could do this. Differential Revision: [D34660829](https://our.internmc.facebook.com/intern/diff/D34660829/) [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit f95919d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
CI Flow Status⚛️ CI FlowRuleset - Version:
|
swolchok
added a commit
that referenced
this pull request
Mar 5, 2022
…stedTensorImpl NestedTensorImpl doesn't have sizes(). Silently getting wrong results back from it is not conducive to efficient software development. Make it throw while allowing sizes() to be inlined in the common case anyway, just like is_contiguous(). Thanks ezyang for the reminder that we could do this. Differential Revision: [D34660829](https://our.internmc.facebook.com/intern/diff/D34660829/) ghstack-source-id: 150608338 Pull Request resolved: #73817
ezyang
approved these changes
Mar 8, 2022
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Approving for speed. I'm wondering how much we actually want to use two bits on the policy; maybe we can do the error case by just going to the dynamic dispatch (and then having that raise the error).
Contributor
Author
I don't think we have a use case for the dynamic dispatch yet, which is why it's not even implemented. I could make it 1 bit but I think that would raise bc issues if we add the dynamic dispatch? We can always make the storage 1 bit despite having the 3 cases in the policy if we need the bit back. |
…e it for NestedTensorImpl" NestedTensorImpl doesn't have sizes(). Silently getting wrong results back from it is not conducive to efficient software development. Make it throw while allowing sizes() to be inlined in the common case anyway, just like is_contiguous(). Thanks ezyang for the reminder that we could do this. Differential Revision: [D34660829](https://our.internmc.facebook.com/intern/diff/D34660829/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Mar 8, 2022
…stedTensorImpl Pull Request resolved: #73817 NestedTensorImpl doesn't have sizes(). Silently getting wrong results back from it is not conducive to efficient software development. Make it throw while allowing sizes() to be inlined in the common case anyway, just like is_contiguous(). Thanks @ezyang for the reminder that we could do this. ghstack-source-id: 150814799 Differential Revision: [D34660829](https://our.internmc.facebook.com/intern/diff/D34660829/)
…e it for NestedTensorImpl" NestedTensorImpl doesn't have sizes(). Silently getting wrong results back from it is not conducive to efficient software development. Make it throw while allowing sizes() to be inlined in the common case anyway, just like is_contiguous(). Thanks ezyang for the reminder that we could do this. Differential Revision: [D34660829](https://our.internmc.facebook.com/intern/diff/D34660829/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Mar 14, 2022
…stedTensorImpl Pull Request resolved: #73817 NestedTensorImpl doesn't have sizes(). Silently getting wrong results back from it is not conducive to efficient software development. Make it throw while allowing sizes() to be inlined in the common case anyway, just like is_contiguous(). Thanks @ezyang for the reminder that we could do this. ghstack-source-id: 151302903 Differential Revision: [D34660829](https://our.internmc.facebook.com/intern/diff/D34660829/)
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
…stedTensorImpl (#73817) Summary: Pull Request resolved: #73817 NestedTensorImpl doesn't have sizes(). Silently getting wrong results back from it is not conducive to efficient software development. Make it throw while allowing sizes() to be inlined in the common case anyway, just like is_contiguous(). Thanks ezyang for the reminder that we could do this. ghstack-source-id: 151302903 Test Plan: Updated test_nestedtensor.py Reviewed By: ezyang Differential Revision: D34660829 fbshipit-source-id: 1289f21127d6a8359893f9174f3c430a290f2c7f
Contributor
|
Hey @swolchok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
NestedTensorImpl doesn't have sizes(). Silently getting wrong results back from it is not conducive to efficient software development. Make it throw while allowing sizes() to be inlined in the common case anyway, just like is_contiguous(). Thanks @ezyang for the reminder that we could do this.
Differential Revision: D34660829