[fx/graph_drawer] Add skip_node_names_in_args option, default to True #73815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit af4f522 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34659144 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34659144 |
jfix71
added
topic: improvements
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34659144 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34659144 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34659144 |
…pytorch#73815) Summary: Pull Request resolved: pytorch#73815 Add `skip_node_names_in_args` (default=`True`) which will skip including node names in args/kwargs during graph drawing. Test Plan: Default (`skip_node_names_in_args=True`): {F707455583} Vs. `skip_node_names_in_args=False`: {F707046375} Reviewed By: wushirong Differential Revision: D34659144 fbshipit-source-id: 918c348c853a1931522567851085f4122dd13141
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34659144 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
…#73815) Summary: Pull Request resolved: #73815 Add `skip_node_names_in_args` (default=`True`) which will skip including node names in args/kwargs during graph drawing. Test Plan: Default (`skip_node_names_in_args=True`): {F707455583} Vs. `skip_node_names_in_args=False`: {F707046375} Reviewed By: wushirong Differential Revision: D34659144 fbshipit-source-id: 9f0bd7bee98dc1ca8eecdabc960804564d83777b
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
… (#73815) Summary: Pull Request resolved: pytorch/pytorch#73815 Add `skip_node_names_in_args` (default=`True`) which will skip including node names in args/kwargs during graph drawing. Test Plan: Default (`skip_node_names_in_args=True`): {F707455583} Vs. `skip_node_names_in_args=False`: {F707046375} Reviewed By: wushirong Differential Revision: D34659144 fbshipit-source-id: 9f0bd7bee98dc1ca8eecdabc960804564d83777b (cherry picked from commit a0ed64b51f0187115586f4001dc81148c7ed18b9)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
… (#73815) Summary: Pull Request resolved: pytorch/pytorch#73815 Add `skip_node_names_in_args` (default=`True`) which will skip including node names in args/kwargs during graph drawing. Test Plan: Default (`skip_node_names_in_args=True`): {F707455583} Vs. `skip_node_names_in_args=False`: {F707046375} Reviewed By: wushirong Differential Revision: D34659144 fbshipit-source-id: 9f0bd7bee98dc1ca8eecdabc960804564d83777b (cherry picked from commit a0ed64b51f0187115586f4001dc81148c7ed18b9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add
skip_node_names_in_args(default=True) which will skip including node names in args/kwargs during graph drawing.Test Plan:
Default (
skip_node_names_in_args=True):{F707046293}
Vs.
skip_node_names_in_args=False:{F707046375}
Differential Revision: D34659144