[Quant][test] Added test to check if fp16 packing->unpacking yields the same result as to(torch.float16).to(torch.float32) [reland] #73808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he same result as to(torch.float16).to(torch.float32) [reland] Summary: A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32) Test Plan: in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f (cherry picked from commit ac8910e) ghstack-source-id: 29eee78 [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
dzdang
added a commit
that referenced
this pull request
Mar 4, 2022
…he same result as to(torch.float16).to(torch.float32) [reland] Summary: A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32) Test Plan: in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f (cherry picked from commit ac8910e) ghstack-source-id: 29eee78 ghstack-source-id: 29eee78 Pull Request resolved: #73808
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 27211f7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ng yields the same result as to(torch.float16).to(torch.float32) [reland]" Summary: A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32) Test Plan: in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f (cherry picked from commit ac8910e) Differential Revision: [D34650372](https://our.internmc.facebook.com/intern/diff/D34650372) [ghstack-poisoned]
dzdang
added a commit
that referenced
this pull request
Mar 5, 2022
…he same result as to(torch.float16).to(torch.float32) [reland] Summary: A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32) Test Plan: in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f (cherry picked from commit ac8910e) ghstack-source-id: f6bde02 ghstack-source-id: f6bde02 Pull Request resolved: #73808
…ng yields the same result as to(torch.float16).to(torch.float32) [reland]" Summary: A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32) Test Plan: in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f (cherry picked from commit ac8910e) Differential Revision: [D34650372](https://our.internmc.facebook.com/intern/diff/D34650372) [ghstack-poisoned]
dzdang
added a commit
that referenced
this pull request
Mar 6, 2022
…he same result as to(torch.float16).to(torch.float32) [reland] Summary: A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32) Test Plan: in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f (cherry picked from commit ac8910e) ghstack-source-id: 74934b4 ghstack-source-id: 74934b4 Pull Request resolved: #73808
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ng yields the same result as to(torch.float16).to(torch.float32) [reland]" Summary: A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32) Test Plan: in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_linear_prepack_fp16_numerics ``` Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f (cherry picked from commit ac8910e) Differential Revision: [D34650372](https://our.internmc.facebook.com/intern/diff/D34650372) [ghstack-poisoned]
dzdang
added a commit
that referenced
this pull request
Mar 7, 2022
…he same result as to(torch.float16).to(torch.float32) [reland] Summary: A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32) Test Plan: in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_linear_prepack_fp16_numerics ``` Reviewed By: jerryzh168 Pulled By: dzdang fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f (cherry picked from commit ac8910e) ghstack-source-id: 69c9ce7 ghstack-source-id: 69c9ce7 Pull Request resolved: #73808
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
approved these changes
Mar 9, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
…he same result as to(torch.float16).to(torch.float32) [reland] (#73808) Summary: Pull Request resolved: #73808 A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32) Test Plan: in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_linear_prepack_fp16_numerics ``` in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` in pytorch main directory, execute ``` python test/test_quantization.py TestDynamicQuantizedOps.test_pack_unpack_fp16 ``` Imported from OSS Pulled By: dzdang fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f (cherry picked from commit ac8910e) dzdang Differential Revision: D34650372 D34650372 fbshipit-source-id: f58a2a964ddf259af3909b0e961d0b0dfd0e35e2
Contributor
|
Hey @dzdang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
A test was added in test_quantized_op.py that checks whether the fp16 packing and subsequent unpacking of a given fp32 tensor produces the same result as to(torch.float16).to(torch.float32)
Test Plan:
in pytorch main directory, execute
Reviewed By: jerryzh168
Pulled By: dzdang
fbshipit-source-id: 5da453e5db4801dde196424282140726c8a4ef1f
(cherry picked from commit ac8910e)
Differential Revision: D34650372