[Easy][FSDP] Fix warning render #73786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit bafc869 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
This was referenced Mar 4, 2022
Collaborator
Author
|
@awgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zhaojuanmao
approved these changes
Mar 4, 2022
Collaborator
Author
|
@awgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
Collaborator
Author
|
@awgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
Summary: Pull Request resolved: #73786 If you check the `master` docs (https://pytorch.org/docs/master/fsdp.html?highlight=fsdp#module-torch.distributed.fsdp), the warning does not render due to missing a `:`. Test Plan: Imported from OSS Reviewed By: zhaojuanmao Differential Revision: D34643837 Pulled By: awgu fbshipit-source-id: cf1a3250840a3923946b5042e2939a1f05e8b490
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#73786 If you check the `master` docs (https://pytorch.org/docs/master/fsdp.html?highlight=fsdp#module-torch.distributed.fsdp), the warning does not render due to missing a `:`. Test Plan: Imported from OSS Reviewed By: zhaojuanmao Differential Revision: D34643837 Pulled By: awgu fbshipit-source-id: cf1a3250840a3923946b5042e2939a1f05e8b490 (cherry picked from commit fef0f0be896f5605645d602ca38da19b696ac3ca)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#73786 If you check the `master` docs (https://pytorch.org/docs/master/fsdp.html?highlight=fsdp#module-torch.distributed.fsdp), the warning does not render due to missing a `:`. Test Plan: Imported from OSS Reviewed By: zhaojuanmao Differential Revision: D34643837 Pulled By: awgu fbshipit-source-id: cf1a3250840a3923946b5042e2939a1f05e8b490 (cherry picked from commit fef0f0be896f5605645d602ca38da19b696ac3ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
no_sync()#73535 [FSDP] Add grad accumulation withoutno_sync()If you check the
masterdocs (https://pytorch.org/docs/master/fsdp.html?highlight=fsdp#module-torch.distributed.fsdp), the warning does not render due to missing a:.Differential Revision: D34643837