[JIT] call super().setUp() in test_jit_fuser_te.py #73762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestCase.setUp() controls @slowtest behavior, so calling super().setUp() will prevent fast tests from running in the slow test CI jobs. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e6c67d8 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
TestCase.setUp() controls slowTest behavior, so calling super().setUp() will prevent fast tests from running in the slow test CI jobs. example: https://github.com/pytorch/pytorch/runs/5413135014?check_suite_focus=true: despite PYTORCH_TEST_SKIP_FAST=1, TestTEFuserStatic tests are still running Differential Revision: [D34628769](https://our.internmc.facebook.com/intern/diff/D34628769) [ghstack-poisoned]
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
TestCase.setUp() controls slowTest behavior, so calling super().setUp() will prevent fast tests from running in the slow test CI jobs. example: https://github.com/pytorch/pytorch/runs/5413135014?check_suite_focus=true: despite PYTORCH_TEST_SKIP_FAST=1, TestTEFuserStatic tests are still running Differential Revision: [D34628769](https://our.internmc.facebook.com/intern/diff/D34628769) [ghstack-poisoned]
TestCase.setUp() controls slowTest behavior, so calling super().setUp() will prevent fast tests from running in the slow test CI jobs. example: https://github.com/pytorch/pytorch/runs/5413135014?check_suite_focus=true: despite PYTORCH_TEST_SKIP_FAST=1, TestTEFuserStatic tests are still running Differential Revision: [D34628769](https://our.internmc.facebook.com/intern/diff/D34628769) [ghstack-poisoned]
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
TestCase.setUp() controls slowTest behavior, so calling super().setUp() will prevent fast tests from running in the slow test CI jobs. example: https://github.com/pytorch/pytorch/runs/5413135014?check_suite_focus=true: despite PYTORCH_TEST_SKIP_FAST=1, TestTEFuserStatic tests are still running Differential Revision: [D34628769](https://our.internmc.facebook.com/intern/diff/D34628769) [ghstack-poisoned]
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Author
|
@ZolotukhinM turns out there were a few failures due to self.setHooks() and self.clearHooks() (which are called in JitTestCase.setUp()) - can you take a quick look to make sure the changes to make the tests pass are fine? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
Summary: Pull Request resolved: #73762 TestCase.setUp() controls slowTest behavior, so calling super().setUp() will prevent fast tests from running in the slow test CI jobs. example: https://github.com/pytorch/pytorch/runs/5413135014?check_suite_focus=true: despite PYTORCH_TEST_SKIP_FAST=1, TestTEFuserStatic tests are still running Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D34628769 Pulled By: davidberard98 fbshipit-source-id: 84311ec1db2ac60fcafb7b77f377e9ae2ef792e3
davidberard98
added a commit
that referenced
this pull request
Mar 21, 2022
Same as #73762. This will make these tests obey PYTORCH_TEST_WITH_SLOW and PYTORCH_TEST_SKIP_FAST [ghstack-poisoned]
davidberard98
added a commit
that referenced
this pull request
Mar 22, 2022
… test_tensorexpr.py" Same as #73762. This will make these tests obey PYTORCH_TEST_WITH_SLOW and PYTORCH_TEST_SKIP_FAST Differential Revision: [D35036771](https://our.internmc.facebook.com/intern/diff/D35036771) [ghstack-poisoned]
davidberard98
added a commit
that referenced
this pull request
Mar 22, 2022
….py" Same as #73762. This will make these tests obey PYTORCH_TEST_WITH_SLOW and PYTORCH_TEST_SKIP_FAST Differential Revision: [D35036771](https://our.internmc.facebook.com/intern/diff/D35036771) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
Summary: Pull Request resolved: #74504 Same as #73762. This will make these tests obey PYTORCH_TEST_WITH_SLOW and PYTORCH_TEST_SKIP_FAST Test Plan: Imported from OSS Reviewed By: ZolotukhinM Differential Revision: D35036771 Pulled By: davidberard98 fbshipit-source-id: a456c109cda365839cda56758ca4d6873e9e159c
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 22, 2022
Summary: Pull Request resolved: #74504 Same as #73762. This will make these tests obey PYTORCH_TEST_WITH_SLOW and PYTORCH_TEST_SKIP_FAST Test Plan: Imported from OSS Reviewed By: ZolotukhinM Differential Revision: D35036771 Pulled By: davidberard98 fbshipit-source-id: a456c109cda365839cda56758ca4d6873e9e159c (cherry picked from commit eeb70f5)
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: #74504 Same as #73762. This will make these tests obey PYTORCH_TEST_WITH_SLOW and PYTORCH_TEST_SKIP_FAST Test Plan: Imported from OSS Reviewed By: ZolotukhinM Differential Revision: D35036771 Pulled By: davidberard98 fbshipit-source-id: a456c109cda365839cda56758ca4d6873e9e159c (cherry picked from commit eeb70f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
TestCase.setUp() controls @slowtest behavior, so calling super().setUp() will prevent fast tests from running in the slow test CI jobs.
example: https://github.com/pytorch/pytorch/runs/5413135014?check_suite_focus=true: despite PYTORCH_TEST_SKIP_FAST=1, TestTEFuserStatic tests are still running
Differential Revision: D34628769