[PyTorch] [Model Tracer] Use c10::Synchronized<T> for build features tracer #73725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracer Currently, the build features tracer relies on the user to for advisory locking of the mutex when accessing shared data structures. This changes it to be mandatory locking using the `c10::Synchronized<T>` abstraction. Differential Revision: [D34604066](https://our.internmc.facebook.com/intern/diff/D34604066/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 557ee24 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 3, 2022
dhruvbird
added a commit
that referenced
this pull request
Mar 3, 2022
…tracer Currently, the build features tracer relies on the user to for advisory locking of the mutex when accessing shared data structures. This changes it to be mandatory locking using the `c10::Synchronized<T>` abstraction. Differential Revision: [D34604066](https://our.internmc.facebook.com/intern/diff/D34604066/) ghstack-source-id: 150407248 Pull Request resolved: #73725
facebook-github-bot
added
the
oncall: jit
…d features tracer" Currently, the build features tracer relies on the user to for advisory locking of the mutex when accessing shared data structures. This changes it to be mandatory locking using the `c10::Synchronized<T>` abstraction. Differential Revision: [D34604066](https://our.internmc.facebook.com/intern/diff/D34604066/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
…tracer (#73725) Summary: Pull Request resolved: #73725 Currently, the build features tracer relies on the user to for advisory locking of the mutex when accessing shared data structures. This changes it to be mandatory locking using the `c10::Synchronized<T>` abstraction. ghstack-source-id: 150407248 Test Plan: Built model tracer successfully using: ``` buck build -c pt.disable_per_op_profiling=0 -c pt.enable_record_kernel_dtype=1 --show-output xplat/caffe2/fb/model_tracer:model_tracer ``` Reviewed By: JacobSzwejbka Differential Revision: D34604066 fbshipit-source-id: 29c5c23264f7bd7e13d0fb9dbc218af5663d06e9
Contributor
|
This pull request has been reverted by 747c6fd. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Contributor
|
This pull request has been reverted by 747c6fd. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Currently, the build features tracer relies on the user to for advisory locking of the mutex when accessing shared data structures. This changes it to be mandatory locking using the
c10::Synchronized<T>abstraction.Differential Revision: D34604066