Get rid of DefaultNumBailouts #73689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 715b8b6 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 Lint / mypy |
Run mypy | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
facebook-github-bot
added
the
oncall: jit
The number of bailouts of each executor should just be instantiated from whatever the current fusion strategy is, which is then stored on the executor. [ghstack-poisoned]
The number of bailouts of each executor should just be instantiated from whatever the current fusion strategy is, which is then stored on the executor. [ghstack-poisoned]
The number of bailouts of each executor should just be instantiated from whatever the current fusion strategy is, which is then stored on the executor. [ghstack-poisoned]
The number of bailouts of each executor should just be instantiated from whatever the current fusion strategy is, which is then stored on the executor. [ghstack-poisoned]
The number of bailouts of each executor should just be instantiated from whatever the current fusion strategy is, which is then stored on the executor. [ghstack-poisoned]
This was referenced Mar 7, 2022
Closed
The number of bailouts of each executor should just be instantiated from whatever the current fusion strategy is, which is then stored on the executor. [ghstack-poisoned]
eellison
commented
Mar 7, 2022
| # we haven't tested every single test in this file | ||
| # but we enable FULL_PROFILER for a large subset | ||
| # of the tests with "with enable_profiling_mode_for_profiling_tests" | ||
| torch._C._jit_set_profiling_mode(False) |
Contributor
Author
There was a problem hiding this comment.
also updates this finally, needed to fix a couple tests @Krovatkin
The number of bailouts of each executor should just be instantiated from whatever the current fusion strategy is, which is then stored on the executor. [ghstack-poisoned]
davidberard98
approved these changes
Mar 8, 2022
Contributor
davidberard98
left a comment
davidberard98
left a comment
There was a problem hiding this comment.
Awesome! Looks good to me
nit: is there a reason we can't get rid of all the bailOut arguments, e.g. in graph_executor.cpp? It doesn't seem like they are used anywhere
The number of bailouts of each executor should just be instantiated from whatever the current fusion strategy is, which is then stored on the executor. [ghstack-poisoned]
This was referenced Mar 10, 2022
Closed
Contributor
Author
i think some of it is still being used for passing in the number of remaining specializations.. but yea some cleanup could probably still be done |
NesrineMHB
pushed a commit
to NesrineMHB/pytorch
that referenced
this pull request
Apr 8, 2022
ghstack-source-id: 2cb01bd Pull Request resolved: pytorch/pytorch#73875 Get rid of DefaultNumBailouts Pull Request resolved: pytorch/pytorch#73689
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The number of bailouts of each executor should just be instantiated from whatever the current fusion strategy is, which is then stored on the executor.