[Quant][core] Merged conv packed params and linear packed params #73486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ff74e5f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
dzdang
added a commit
that referenced
this pull request
Feb 27, 2022
Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. ghstack-source-id: 7a00e5b Pull Request resolved: #73486
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
jerryzh168
approved these changes
Mar 3, 2022
Contributor
jerryzh168
left a comment
jerryzh168
left a comment
There was a problem hiding this comment.
looks good, please make sure to fix all lint errors and make sure all the tests passes before landing
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
2 similar comments
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
This was referenced Mar 9, 2022
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
…params" Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: [D34513286](https://our.internmc.facebook.com/intern/diff/D34513286) [ghstack-poisoned]
Contributor
Author
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to pytorch/glow
that referenced
this pull request
Mar 11, 2022
Summary: X-link: pytorch/pytorch#73486 conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: D34513286 D34513286 Reviewed By: dagitses Pulled By: dzdang fbshipit-source-id: 813845af7ea9449e316ab7822efe7460f0bd0d88
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
) Summary: Pull Request resolved: #73486 conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>. Differential Revision: D34513286 D34513286 Test Plan: Imported from OSS Reviewed By: dagitses Pulled By: dzdang fbshipit-source-id: 813845af7ea9449e316ab7822efe7460f0bd0d88
Contributor
|
Hey @dzdang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: conv and linear packed params were previously defined in ATen/native/quantized/cpu/conv_packed_params.h> and ATen/native/quantized/cpu/packed_params.h>. These two files have been merged into one and has been relocated to ATen/native/quantized/cpu/packed_params.h>.
Differential Revision: D34513286