Cleanup C10::Scalar stringification #73462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Because `operator<<` for Scalar is in `namespace at`, overload resolution fails very outside of `at`. By moving to `c10`, `namespace c10` will be included in the candidates due to the Scalar arg. I also didn't a good reason for the definition to be inline, and we're missing a `toString` overload so I added one. Test Plan: Template deduction during compile should be sufficient. Differential Revision: D34483818 fbshipit-source-id: 9f90b3e0d5b50d74d41b98c4dec978a335413c76
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0055e7f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34483818 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
Summary: Pull Request resolved: #73462 Because `operator<<` for Scalar is in `namespace at`, overload resolution fails very outside of `at`. Moving to `c10` fixes this because `namespace c10` will be included in the candidates due to the Scalar arg. I also didn't a good reason for the definition to be inline, and we're missing a `toString` overload so I added one. Test Plan: Template deduction during compile should be sufficient. Reviewed By: ezyang Differential Revision: D34483818 fbshipit-source-id: 24007dde32db447046266c17517f62a2ac4b29cc
Contributor
|
Hey @robieta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Because
operator<<for Scalar is innamespace at, overload resolution fails very outside ofat. By moving toc10,namespace c10will be included in the candidates due to the Scalar arg. I also didn't a good reason for the definition to be inline, and we're missing atoStringoverload so I added one.Test Plan: Template deduction during compile should be sufficient.
Differential Revision: D34483818