Add back SLEEF and also use better cmake setup. #7341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
cpuhrsch
changed the title
cpuhrsch
force-pushed
the
revertrevertsleef
branch
2 times, most recently
from
d8a061b to
14c168d
Compare
cpuhrsch
force-pushed
the
revertrevertsleef
branch
from
14c168d to
43bf9ce
Compare
soumith
approved these changes
May 8, 2018
Contributor
Author
|
@pytorchbot retest this please |
cpuhrsch
force-pushed
the
revertrevertsleef
branch
2 times, most recently
from
ed2c270 to
a0bb4a3
Compare
cpuhrsch
force-pushed
the
revertrevertsleef
branch
from
a0bb4a3 to
1b83f16
Compare
onnxbot
added a commit
to onnxbot/onnx-fb-universe
that referenced
this pull request
May 9, 2018
Closed
weiyangfb
pushed a commit
to weiyangfb/pytorch
that referenced
this pull request
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bcffb5a and replaces our custom cmake setup with the official one.