[Profiler] Specialized AppendOnlyQueue #73409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ea050e7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34231072 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34231072 |
robieta
force-pushed
the
export-D34231072
branch
from
5d755d4 to
8fcf1d0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34231072 |
robieta
force-pushed
the
export-D34231072
branch
from
8fcf1d0 to
fda6ee7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34231072 |
robieta
force-pushed
the
export-D34231072
branch
from
fda6ee7 to
f2a2d9f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34231072 |
robieta
force-pushed
the
export-D34231072
branch
from
f2a2d9f to
64303e5
Compare
Summary: Pull Request resolved: pytorch#73409 We can do better than `vector` or `deque`, and it's sufficiently important to the hot path to justify a custom container. (This is part of the larger queue refactor, but this is a standalone drop-in replacement so we don't need to wait.) Test Plan: It's a pretty simple container type, so I just added a few cpp tests for emplace and read back. I also ran the overhead benchmark (replicates=9) with both `--stressTestKineto` (0.99 -> 0.94 us) and `--stressTestKineto --kinetoProfileMemory` (1.36 -> 1.27 us). Reviewed By: swolchok Differential Revision: D34231072 fbshipit-source-id: fccbc9ab7adaa1645c631fee6aa85787f85df599
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34231072 |
robieta
force-pushed
the
export-D34231072
branch
from
64303e5 to
ea050e7
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
Summary: Pull Request resolved: #73409 We can do better than `vector` or `deque`, and it's sufficiently important to the hot path to justify a custom container. (This is part of the larger queue refactor, but this is a standalone drop-in replacement so we don't need to wait.) Test Plan: It's a pretty simple container type, so I just added a few cpp tests for emplace and read back. I also ran the overhead benchmark (replicates=9) with both `--stressTestKineto` (0.99 -> 0.94 us) and `--stressTestKineto --kinetoProfileMemory` (1.36 -> 1.27 us). Reviewed By: swolchok Differential Revision: D34231072 fbshipit-source-id: ed57299729d444d59cf843a0d38a3ee2240eeec1
aaronenyeshi
approved these changes
Mar 11, 2022
Contributor
|
Hey @robieta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We can do better than
vectorordeque, and it's sufficiently important to the hot path to justify a custom container. (This is part of the larger queue refactor, but this is a standalone drop-in replacement so we don't need to wait.)Test Plan: It's a pretty simple container type, so I just added a few cpp tests for emplace and read back. I also ran the overhead benchmark (replicates=9) with both
--stressTestKineto(0.99 -> 0.94 us) and--stressTestKineto --kinetoProfileMemory(1.36 -> 1.27 us).Differential Revision: D34231072