[fx][acc_tracer] fix defaulted placeholder normalization #73406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e881c1e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34463493 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34463493 |
alexbeloi
force-pushed
the
export-D34463493
branch
from
4454410 to
113e94e
Compare
Summary: Pull Request resolved: pytorch#73406 Placeholder defaults are stored in `node.args`, during normalization we had dropped these. This diff passes the default args through the normalization transformation. Test Plan: Added tests to cover cases with optional inputs, test covers * nothing passed to optional input * `None` passed to optional input * a tensor passed to optional input Reviewed By: jfix71 Differential Revision: D34463493 fbshipit-source-id: 02bfa84229c0dd940d05a51d4c26e4c0c1f078c9
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34463493 |
alexbeloi
force-pushed
the
export-D34463493
branch
from
113e94e to
e881c1e
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 12, 2022
Summary: Pull Request resolved: #73406 Placeholder defaults are stored in `node.args`, during normalization we had dropped these. This diff passes the default args through the normalization transformation. Test Plan: Added tests to cover cases with optional inputs, test covers * nothing passed to optional input * `None` passed to optional input * a tensor passed to optional input Reviewed By: jfix71 Differential Revision: D34463493 fbshipit-source-id: f0c3a4083cb3dd4a69111a758561f0d2c0609787
Contributor
|
Hey @alexbeloi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Placeholder defaults are stored in
node.args, during normalization we had dropped these. This diff passes the default args through the normalization transformation.Test Plan:
Added tests to cover cases with optional inputs, test covers
Nonepassed to optional inputDifferential Revision: D34463493