[ONNX] Add module name as PythonOp attribute (#67193) #73281

BowenBao · 2022-02-23T06:58:02Z

Stack from ghstack:

[ONNX] Support optional type (#68793) #73284
[ONNX] Add symbolic support for torch.nn.cosinesimilarity (#72128) #73283
[ONNX] use onnxruntime 1.10 in CI (#69271) #73282
-> [ONNX] Add module name as PythonOp attribute (#67193) #73281
[ONNX] Adds overload_name to Aten op (#69378) #73280
Add module name as pythonOp attr
Move to trace_post_record
Add tests
Code compactness

Differential Revision: D34625647

* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness [ghstack-poisoned]

pytorch-bot · 2022-02-23T06:58:05Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/73a94cb697bc4afe0aaac3b0469665dce9e7fd8e/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-arm64-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-arm64-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
macos-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`, `ciflow/xla`	🚫 skipped

facebook-github-bot · 2022-02-23T06:58:10Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/73281
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 9a089b9 (more details on the Dr. CI page):

2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-xenial-cuda11.3-py3.7-gcc7 / test (default, 2, 2, linux.4xlarge.nvidia.gpu) (1/2)

Step: "Unknown" (full log | diagnosis details | 🔁 rerun)

2022-03-02T21:24:27.2914063Z test_add_done_ca...arg() takes 0 positional arguments but 1 was given

2022-03-02T21:24:27.2883712Z   /opt/conda/lib/python3.7/unittest/suite.py(122): run
2022-03-02T21:24:27.2884069Z   /opt/conda/lib/python3.7/unittest/suite.py(84): __call__
2022-03-02T21:24:27.2884522Z   /opt/conda/lib/python3.7/site-packages/xmlrunner/runner.py(67): run
2022-03-02T21:24:27.2884896Z   /opt/conda/lib/python3.7/unittest/main.py(271): runTests
2022-03-02T21:24:27.2885216Z   /opt/conda/lib/python3.7/unittest/main.py(101): __init__
2022-03-02T21:24:27.2885709Z   /opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py(655): run_tests
2022-03-02T21:24:27.2886076Z   test_futures.py(331): <module>
2022-03-02T21:24:27.2886229Z 
2022-03-02T21:24:27.2886330Z ok (1.555s)
2022-03-02T21:24:27.2907523Z   test_add_done_callback_maintains_callback_order (__main__.TestFuture) ... ok (0.003s)
2022-03-02T21:24:27.2914063Z   test_add_done_callback_no_arg_error_is_ignored (__main__.TestFuture) ... [E pybind_utils.h:201] Got the following error when running the callback: TypeError: no_arg() takes 0 positional arguments but 1 was given
2022-03-02T21:24:27.2916061Z ok (0.001s)
2022-03-02T21:24:27.2929921Z   test_add_done_callback_simple (__main__.TestFuture) ... ok (0.001s)
2022-03-02T21:24:27.2990279Z   test_chained_then (__main__.TestFuture) ... ok (0.006s)
2022-03-02T21:24:27.4012634Z   test_collect_all (__main__.TestFuture) ... ok (0.102s)
2022-03-02T21:24:27.4021066Z   test_done (__main__.TestFuture) ... ok (0.001s)
2022-03-02T21:24:27.4035660Z   test_done_exception (__main__.TestFuture) ... ok (0.001s)
2022-03-02T21:24:27.4057203Z   test_interleaving_then_and_add_done_callback_maintains_callback_order (__main__.TestFuture) ... ok (0.002s)
2022-03-02T21:24:27.4069036Z   test_interleaving_then_and_add_done_callback_propagates_error (__main__.TestFuture) ... [E pybind_utils.h:201] Got the following error when running the callback: ValueError: Expected error
2022-03-02T21:24:27.4069409Z 
2022-03-02T21:24:27.4069501Z At:

linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-02T19:33:02.3936186Z The PR is introduc...m to confirm whether this change is wanted or not.

2022-03-02T19:33:02.3923994Z processing existing schema:  text(__torch__.torch.classes.profiling.SourceRef _0) -> (str _0)
2022-03-02T19:33:02.3925727Z processing existing schema:  count(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-03-02T19:33:02.3926488Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-03-02T19:33:02.3927776Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> (__torch__.torch.classes.profiling.SourceRef _0)
2022-03-02T19:33:02.3929514Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> (Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0)
2022-03-02T19:33:02.3930311Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-03-02T19:33:02.3931732Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-03-02T19:33:02.3933529Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-03-02T19:33:02.3934412Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> (__torch__.torch.classes.profiling.SourceStats[] _0)
2022-03-02T19:33:02.3935950Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (NoneType _0)
2022-03-02T19:33:02.3936186Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-03-02T19:33:02.3936197Z 
2022-03-02T19:33:02.3936267Z Broken ops: [
2022-03-02T19:33:02.3936627Z 	quantized::conv2d_relu_cudnn(Tensor act, Tensor weight, Tensor? bias, int[] stride, int[] padding, int[] dilation, int groups, float output_scale, int output_zero_point) -> (Tensor)
2022-03-02T19:33:02.3936688Z ]
2022-03-02T19:33:02.4732124Z + cleanup
2022-03-02T19:33:02.4732205Z + retcode=1
2022-03-02T19:33:02.4732268Z + set +x
2022-03-02T19:33:02.4771598Z ##[error]Process completed with exit code 1.
2022-03-02T19:33:02.4802081Z ##[group]Run # Ensure the working directory gets chowned back to the current user
2022-03-02T19:33:02.4802256Z �[36;1m# Ensure the working directory gets chowned back to the current user�[0m

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

torch/csrc/autograd/python_function.cpp

* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness [ghstack-poisoned]

malfet · 2022-03-03T22:10:00Z

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Pull Request resolved: #73281 * Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D34625647 Pulled By: malfet fbshipit-source-id: b04b2a4f1dc2cf733fcf50a3b022337f80d6eead

[ONNX] Add module name as PythonOp attribute (#67193)

73a94cb

* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness [ghstack-poisoned]

BowenBao requested review from albanD, shubhambhokare1 and soulitzer as code owners February 23, 2022 06:58

pytorch-bot bot added the ciflow/default label Feb 23, 2022

facebook-github-bot added the cla signed label Feb 23, 2022

This was referenced Feb 23, 2022

[ONNX] Adds overload_name to Aten op (#69378) #73280

Closed

[ONNX] use onnxruntime 1.10 in CI (#69271) #73282

Closed

[ONNX] Add symbolic support for torch.nn.cosinesimilarity (#72128) #73283

Closed

[ONNX] Support optional type (#68793) #73284

Closed

pytorchbot added the open source label Feb 23, 2022

albanD removed their request for review February 23, 2022 14:55

BowenBao added the onnx-needs-import This PR is related to ONNX, but touches files outside of merge rule patterns, and hence needs import label Feb 23, 2022

malfet reviewed Mar 1, 2022

View reviewed changes

torch/csrc/autograd/python_function.cpp Outdated Show resolved Hide resolved

Update on "[ONNX] Add module name as PythonOp attribute (#67193)"

9a089b9

* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness [ghstack-poisoned]

soulitzer removed their request for review March 2, 2022 22:16

malfet approved these changes Mar 3, 2022

View reviewed changes

pytorchmergebot closed this in 341e20a Mar 9, 2022

facebook-github-bot deleted the gh/BowenBao/145/head branch March 12, 2022 15:16

WBobby mentioned this pull request Aug 17, 2022

Add ROCm5.2.3/AMDGPU support for PyTorch WBobby/pytorch#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ONNX] Add module name as PythonOp attribute (#67193) #73281

[ONNX] Add module name as PythonOp attribute (#67193) #73281

Uh oh!

BowenBao commented Feb 23, 2022 •

edited by malfet

Loading

Uh oh!

pytorch-bot bot commented Feb 23, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 23, 2022 •

edited

Loading

Uh oh!

Uh oh!

malfet commented Mar 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[ONNX] Add module name as PythonOp attribute (#67193) #73281

[ONNX] Add module name as PythonOp attribute (#67193) #73281

Uh oh!

Conversation

BowenBao commented Feb 23, 2022 • edited by malfet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Feb 23, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

linux-xenial-cuda11.3-py3.7-gcc7 / test (default, 2, 2, linux.4xlarge.nvidia.gpu) (1/2)

linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/2)

Uh oh!

Uh oh!

malfet commented Mar 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

BowenBao commented Feb 23, 2022 •

edited by malfet

Loading

facebook-github-bot commented Feb 23, 2022 •

edited

Loading