[ONNX] Adds overload_name to Aten op (#69378) #73280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit a204eed (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
facebook-github-bot
added
the
oncall: jit
This was referenced Feb 23, 2022
BowenBao
added
the
onnx-needs-import
malfet
reviewed
Mar 1, 2022
| for (const auto i : c10::irange(operator_def.arg_size())) { | ||
| auto & attr = operator_def.arg(i); | ||
| if(attr.name() == "operator" || attr.name() == "type" ) | ||
| if(attr.name() == "operator" || attr.name() == "type" || attr.name() == "overload_name" ) { |
Contributor
There was a problem hiding this comment.
Hmm, did you get an ack from someone who maintains caffe2 codebase? (Though not sure who owns it right now)
@ezyang do you know by any change?
Collaborator
There was a problem hiding this comment.
Not really, but this is back compatible. overload_name is an optional attribute which is ignored by Caffe2 through the condition above :)
malfet
approved these changes
Mar 1, 2022
This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable [ghstack-poisoned]
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: #73280 This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D34625645 Pulled By: malfet fbshipit-source-id: 37d58cfb5231833768172c122efc42edf7d8609a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code.
This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names.
ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor
The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable
Differential Revision: D34625645