[ONNX] Remove redundant warning for reshape #73265

BowenBao · 2022-02-23T00:38:18Z

The warning is not actionable and seems to be potentially false alarming.

pytorch-bot · 2022-02-23T00:38:22Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/BowenBao/pytorch/blob/68461854dd8683ad893b472ad6b0661adfdd2a19/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-arm64-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-arm64-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
macos-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`, `ciflow/xla`	🚫 skipped

facebook-github-bot · 2022-02-23T00:38:23Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/73265
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 2be2a5a (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-03T23:42:11.2100894Z RuntimeError: tens...OK() (UNKNOWN: Could not start gRPC server vs. OK)

2022-03-03T23:42:11.2093916Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.11-py3.7-linux-x86_64.egg/torch_xla/distributed/xla_multiprocessing.py", line 314, in _setup_replication
2022-03-03T23:42:11.2094629Z     device = xm.xla_device()
2022-03-03T23:42:11.2095299Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.11-py3.7-linux-x86_64.egg/torch_xla/core/xla_model.py", line 232, in xla_device
2022-03-03T23:42:11.2095695Z     devkind=devkind if devkind is not None else None)
2022-03-03T23:42:11.2096148Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.11-py3.7-linux-x86_64.egg/torch_xla/core/xla_model.py", line 137, in get_xla_supported_devices
2022-03-03T23:42:11.2098320Z     xla_devices = _DEVICES.value
2022-03-03T23:42:11.2099112Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.11-py3.7-linux-x86_64.egg/torch_xla/utils/utils.py", line 32, in value
2022-03-03T23:42:11.2099650Z     self._value = self._gen_fn()
2022-03-03T23:42:11.2100090Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.11-py3.7-linux-x86_64.egg/torch_xla/core/xla_model.py", line 19, in <lambda>
2022-03-03T23:42:11.2100449Z     _DEVICES = xu.LazyProperty(lambda: torch_xla._XLAC._xla_get_devices())
2022-03-03T23:42:11.2100894Z RuntimeError: tensorflow/compiler/xla/xla_client/xrt_local_service.cc:56 : Check failed: tensorflow::NewServer(server_def, &server_) == ::tensorflow::Status::OK() (UNKNOWN: Could not start gRPC server vs. OK)
2022-03-03T23:42:11.3947494Z Traceback (most recent call last):
2022-03-03T23:42:11.3948120Z   File "/var/lib/jenkins/workspace/xla/test/test_mp_replication.py", line 30, in <module>
2022-03-03T23:42:11.3948552Z     xmp.spawn(_mp_fn, args=())
2022-03-03T23:42:11.3949132Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.11-py3.7-linux-x86_64.egg/torch_xla/distributed/xla_multiprocessing.py", line 394, in spawn
2022-03-03T23:42:11.3949460Z     start_method=start_method)
2022-03-03T23:42:11.3949822Z   File "/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 198, in start_processes
2022-03-03T23:42:11.3950104Z     while not context.join():
2022-03-03T23:42:11.3950471Z   File "/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 154, in join
2022-03-03T23:42:11.3950718Z     exit_code=exitcode
2022-03-03T23:42:11.3951029Z torch.multiprocessing.spawn.ProcessExitedException: process 2 terminated with exit code 17

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

BowenBao · 2022-02-23T00:39:06Z

@shubhambhokare1 frankly I don't recall why this warning was there. Please remind me if there was a real issue that it was guarding against.

BowenBao · 2022-02-24T01:07:56Z

onnx failure should be resolved by #73282 with 1.10 ort.

test/onnx/test_pytorch_onnx_onnxruntime.py

torch/onnx/symbolic_helper.py

…Add/re-eanble test.

shubhambhokare1

LGTM

BowenBao · 2022-03-14T18:26:52Z

cc @garymm for merge approval

garymm

@pytorchbot merge this

pytorch-bot · 2022-03-14T20:57:06Z

+1

github-actions · 2022-03-14T20:59:03Z

Hey @BowenBao.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Fixes #73129. The warning is not actionable and seems to be potentially false alarming. Pull Request resolved: #73265 Approved by: https://github.com/shubhambhokare1, https://github.com/garymm Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/57c7bf7feecc480355bb70631342ef6d68db43e8 Reviewed By: malfet Differential Revision: D34883073 fbshipit-source-id: 82f1eac99ad269282c526bed928bca60d407326d

BowenBao requested a review from shubhambhokare1 as a code owner February 23, 2022 00:38

pytorch-bot bot added the ciflow/default label Feb 23, 2022

facebook-github-bot added the cla signed label Feb 23, 2022

pytorchbot added the open source label Feb 23, 2022

shubhambhokare1 reviewed Feb 24, 2022

View reviewed changes

test/onnx/test_pytorch_onnx_onnxruntime.py Outdated Show resolved Hide resolved

shubhambhokare1 self-assigned this Feb 24, 2022

BowenBao force-pushed the onnx_reshape_redundant_warning branch from 599635d to 435bc50 Compare February 24, 2022 20:17

shubhambhokare1 reviewed Feb 25, 2022

View reviewed changes

torch/onnx/symbolic_helper.py Outdated Show resolved Hide resolved

ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 1, 2022

BowenBao added 6 commits March 2, 2022 15:35

Remove redundant warning

1296fb8

Fix reshape shape inference bug wrt allowzero. Fix reshape symbolic. …

51248be

…Add/re-eanble test.

linter

6534053

skip test and comment with pr link for ort fix

384beca

disable

9f736ce

update skip tests

2be2a5a

BowenBao force-pushed the onnx_reshape_redundant_warning branch from 435bc50 to 2be2a5a Compare March 3, 2022 22:49

BowenBao requested a review from shubhambhokare1 March 3, 2022 22:52

shubhambhokare1 approved these changes Mar 14, 2022

View reviewed changes

garymm approved these changes Mar 14, 2022

View reviewed changes

pytorchmergebot closed this in 57c7bf7 Mar 14, 2022

BowenBao added release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category labels Mar 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ONNX] Remove redundant warning for reshape #73265

[ONNX] Remove redundant warning for reshape #73265

Uh oh!

BowenBao commented Feb 23, 2022

Uh oh!

pytorch-bot bot commented Feb 23, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 23, 2022 •

edited

Loading

Uh oh!

BowenBao commented Feb 23, 2022

Uh oh!

BowenBao commented Feb 24, 2022

Uh oh!

Uh oh!

Uh oh!

shubhambhokare1 left a comment

Uh oh!

BowenBao commented Mar 14, 2022

Uh oh!

garymm left a comment

Uh oh!

pytorch-bot bot commented Mar 14, 2022

Uh oh!

github-actions bot commented Mar 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[ONNX] Remove redundant warning for reshape #73265

[ONNX] Remove redundant warning for reshape #73265

Uh oh!

Conversation

BowenBao commented Feb 23, 2022

Uh oh!

pytorch-bot bot commented Feb 23, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Uh oh!

BowenBao commented Feb 23, 2022

Uh oh!

BowenBao commented Feb 24, 2022

Uh oh!

Uh oh!

Uh oh!

shubhambhokare1 left a comment

Choose a reason for hiding this comment

Uh oh!

BowenBao commented Mar 14, 2022

Uh oh!

garymm left a comment

Choose a reason for hiding this comment

Uh oh!

pytorch-bot bot commented Mar 14, 2022

Uh oh!

github-actions bot commented Mar 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

facebook-github-bot commented Feb 23, 2022 •

edited

Loading