[PyTorch Edge] Use Parallelization in Internal Quantized Matmul #73247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit cee0a2d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Feb 22, 2022
salilsdesai
added a commit
that referenced
this pull request
Feb 22, 2022
Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) ghstack-source-id: 149691337 Pull Request resolved: #73247
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Feb 25, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 150002588 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 1, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 150241218 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 2, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 150355543 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 7, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 150726277 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 8, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 150840723 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 9, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 150916673 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 10, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 151003681 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 10, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 151028027 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 11, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 151138390 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 12, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 151217389 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
…atmul" Split up multiplication over outer dimensions Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/) [ghstack-poisoned]
salilsdesai
added a commit
that referenced
this pull request
Mar 14, 2022
Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 151250864 Differential Revision: [D34012771](https://our.internmc.facebook.com/intern/diff/D34012771/)
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
Summary: Pull Request resolved: #73247 Split up multiplication over outer dimensions ghstack-source-id: 151250864 Test Plan: From fbcode: ```buck test caffe2/test:quantization -- test_qmatmul``` Performance Improvement Summary: For matmuls used by Transformer Model - This diff makes qmatmul ~53% faster than the preceding diff (Ruy without parallelization) - This entire diff stack makes qmatmul ~75% faster than the naive implementation (see below for details) **Detailed Benchmarking Results:** *Benchmarking done by on a model which performs matmuls of the same shapes and counts as Transformer Model, as determined in D30901505* *Notebook in which Benchmarking was performed: https://www.internalfb.com/intern/anp/view/?id=1582075&revision_id=537916317667891* - Ruy QMatMul, Parallelization within PyTorch (this diff, v5): [7.5257ms](https://www.internalfb.com/intern/aibench/details/621856970876663) - Ruy QMatMul, No Parallelization (D33735479, v18): [16.0261ms](https://www.internalfb.com/intern/aibench/details/867786467365069) - Naive QMatMul (on master branch (base of D33332098), v22): [30.9919ms](https://www.internalfb.com/intern/aibench/details/418359955621359) Experiments using Ruy Threadpool (which ended up being bad; abandoning): - Ruy QMatMul, with Ruy Threadpool 4 threads (D34110676, v1): [59.8889ms](https://www.internalfb.com/intern/aibench/details/487293857402229) - Ruy QMatMul, Parallelization within PyTorch and with Ruy Threadpool 4 threads (D34111050, v1): [624.8932 ms (?!)](https://www.internalfb.com/intern/aibench/details/330231112631355) Reviewed By: kimishpatel Differential Revision: D34012771 fbshipit-source-id: 79d137f295b05812968ab53fdf9798606f3f4e63
Contributor
|
Hey @salilsdesai. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Split up multiplication over outer dimensions
Differential Revision: D34012771