[PyTorch Edge] Allow >2 dimensional tensors in internal Quantized Matmul #73246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit dab65b3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Feb 22, 2022
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
…antized Matmul" Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) Differential Revision: [D33735479](https://our.internmc.facebook.com/intern/diff/D33735479/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
…mul (#73246) Summary: Pull Request resolved: #73246 Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s) ghstack-source-id: 151250869 Test Plan: From fbcode: ```buck test caffe2/test:quantization -- test_qmatmul``` Performance Improvement/Benchmarking: See testplan of D34012771 Reviewed By: kimishpatel Differential Revision: D33735479 fbshipit-source-id: b7908e1e78a4ea0c4910fc540c5549e4ec3b7473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Iterate over the outer dimensions. Will be optimized with parallelization in future diff(s)
Differential Revision: D33735479