add to method for PackedSequence
#7319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facaiy
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
facaiy
force-pushed
the
ENH/PackedSequence_support_to_method
branch
from
cf4f997 to
b0692f9
Compare
facaiy
force-pushed
the
ENH/PackedSequence_support_to_method
branch
from
b0692f9 to
d3865ac
Compare
ssnl
reviewed
May 5, 2018
test/test_nn.py
Outdated
| self.assertIs(a, a.to('cpu', dtype=torch.int32)) | ||
| self.assertEqual(a.long(), a.to(torch.int64)) | ||
|
|
||
| if torch.cuda.data.is_available(): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ssnl
reviewed
May 5, 2018
torch/nn/utils/rnn.py
Outdated
| return type(self)(self.data.byte(), self.batch_sizes) | ||
|
|
||
| def to(self, *args, **kwargs): | ||
| r"""Performs dtype and/or device conversion on `self.data`""" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@ssnl Thanks for your review. I think I have resolved both your comments, could you take a look again? |
ssnl
reviewed
May 6, 2018
test/test_nn.py
Outdated
| self.assertEqual(a.long(), a.to(torch.int64)) | ||
|
|
||
| if torch.cuda.is_available(): | ||
| for cuda in ['cuda', 'cuda:0' if torch.cuda.data.device_count() == 1 else 'cuda:1']: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Collaborator
|
By the way, you can also look at the CI logs to see the failures. |
Contributor
Author
|
@ssnl Thank you for your help. |
ssnl
approved these changes
May 7, 2018
soumith
approved these changes
May 7, 2018
onnxbot
added a commit
to onnxbot/onnx-fb-universe
that referenced
this pull request
May 7, 2018
weiyangfb
pushed a commit
to weiyangfb/pytorch
that referenced
this pull request
Jun 11, 2018
* ENH: add to method for PackedSequence * ENH: return self if possible * TST: remove extra data * DOC: add more explanation * TST: remove extra data * DOC: minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7221.
It's my first contribution to pytorch, so any help would be appreciated. Thanks.