[FSDP] Make summon_full_params a public method #73116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
fegin
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c981be7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
fegin
added a commit
that referenced
this pull request
Feb 18, 2022
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) ghstack-source-id: 149524472 Pull Request resolved: #73116
rohan-varma
approved these changes
Feb 22, 2022
Contributor
rohan-varma
left a comment
rohan-varma
left a comment
There was a problem hiding this comment.
I think we can do this as long as we have consensus on name, API, defaults, etc.
The main thing I think will be the default setting of writeback which is currently True, users will have to explicitly pass in writeback=False to get better perf. However summon_full_params is mostly for debugging, or checkpointing and I think the usability improvement is worth the tradeoff here. We can also always flip the param if need be before the release.
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Feb 23, 2022
Pull Request resolved: #73116 Users may need summon_full_params() to get the original parameters. ghstack-source-id: 149776412 Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/)
Contributor
Author
|
@rohan-varma agree. The default value of write_back should be False. |
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Feb 23, 2022
Pull Request resolved: #73116 Users may need summon_full_params() to get the original parameters. ghstack-source-id: 149787096 Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/)
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Feb 23, 2022
Pull Request resolved: #73116 Users may need summon_full_params() to get the original parameters. ghstack-source-id: 149807641 Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/)
rohan-varma
reviewed
Feb 23, 2022
Contributor
rohan-varma
left a comment
rohan-varma
left a comment
There was a problem hiding this comment.
@fegin Maybe I miscommunicated, but why should it be False over the current True? From what I understand summon_full_params is not currently on a perf critical path, and writeback=True by default is nice because modifications will persist by default (or perhaps modifying state by default is not great?)
Contributor
Author
|
@rohan-varma I misunderstood your original comment. My thought was that |
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Feb 25, 2022
Pull Request resolved: #73116 Users may need summon_full_params() to get the original parameters. ghstack-source-id: 149951203 Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/)
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
Users may need summon_full_params() to get the original parameters. Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Feb 28, 2022
Pull Request resolved: #73116 Users may need summon_full_params() to get the original parameters. ghstack-source-id: 150134237 Differential Revision: [D34353034](https://our.internmc.facebook.com/intern/diff/D34353034/)
This was referenced Feb 28, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
Summary: Pull Request resolved: #73116 Users may need summon_full_params() to get the original parameters. ghstack-source-id: 150134237 Test Plan: CI Reviewed By: rohan-varma Differential Revision: D34353034 fbshipit-source-id: ac69cc032da177903cd9969094f3f82dc6a61636
Contributor
|
Hey @fegin. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#73116 Users may need summon_full_params() to get the original parameters. ghstack-source-id: 150134237 Test Plan: CI Reviewed By: rohan-varma Differential Revision: D34353034 fbshipit-source-id: ac69cc032da177903cd9969094f3f82dc6a61636 (cherry picked from commit 55d34fdee3778110a165a13ae987d0339e8d33c7)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#73116 Users may need summon_full_params() to get the original parameters. ghstack-source-id: 150134237 Test Plan: CI Reviewed By: rohan-varma Differential Revision: D34353034 fbshipit-source-id: ac69cc032da177903cd9969094f3f82dc6a61636 (cherry picked from commit 55d34fdee3778110a165a13ae987d0339e8d33c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Users may need summon_full_params() to get the original parameters.
Differential Revision: D34353034