[Quant] Add ConvTranspose reference module #72473

terrychenism · 2022-02-07T22:55:33Z

Stack from ghstack:

-> [Quant] Add ConvTranspose reference module #72473

Summary:
Add ConvTranspose reference module

Test Plan:
python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op

Reviewers:

Subscribers:

Tasks:

Tags:

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

pytorch-bot · 2022-02-07T22:55:37Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/8580806f6b8a461f2306e9857e701cfb5d3660e1/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`, `ciflow/xla`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

facebook-github-bot · 2022-02-07T22:55:38Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/72473
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit cb8c37b (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1508f64 Pull Request resolved: #72473

terrychenism · 2022-02-07T22:56:49Z

not ready for merge

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 28eb75f Pull Request resolved: #72473

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 65c0b16 Pull Request resolved: #72473

vkuzo · 2022-02-08T13:35:01Z

torch/nn/quantized/_reference/modules/conv.py

+        this is useful when user want to use this module in other backends like Glow.
+    """
+    __annotations__ = {"bias": Optional[torch.Tensor]}
+    _IS_REFERNECE = True


nit: IS_REFERENCE (fix typo)?

vkuzo · 2022-02-08T13:36:35Z

test/quantization/eager/test_quantize_eager_ptq.py

+        class M(torch.nn.Module):
+            def __init__(self):
+                super().__init__()
+                self.conv = nn.ConvTranspose2d(1, 1, 1)


can we test the 1d and 3d variants as well

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2d1b715 Pull Request resolved: #72473

jerryzh168 · 2022-02-08T20:30:06Z

torch/ao/quantization/quantize.py

+            qmod = mapping[type(mod)]
+            if hasattr(qmod, '_IS_REFERENCE') and qmod._IS_REFERENCE:
+                assert mod.qconfig is not None
+                weight_post_process = mod.qconfig.weight()


we need to run the weight_process_process with weight of the module:
weight_post_process(mod.weight)

jerryzh168 · 2022-02-08T20:31:11Z

test/quantization/eager/test_quantize_eager_ptq.py

+                x = self.quant(x)
+                x = self.dequant(x)
+                x = self.conv(x)
+                x = self.quant(x)


is this is the module for reference conv transpose, we need to use two different QuantStubs since they are recording the scale/zero_point at a specific point

jerryzh168 · 2022-02-08T20:32:32Z

test/quantization/eager/test_quantize_eager_ptq.py

+                x = self.dequant(x)
+                return x
+
+        class RefM(torch.nn.Module):


not sure which one you want to use quantized conv transpose (instead of reference), but the one that is using normal path will have one quant and one dequant:

x = self.quant(x) x = self.convtranspose(x) x = self.dequant(x)

since the quantized convtranspose takes quantized Tensor as input and outputs a quantized Tensor

jerryzh168 · 2022-02-08T20:33:25Z

torch/nn/quantized/_reference/modules/conv.py

+    __annotations__ = {"bias": Optional[torch.Tensor]}
+    _IS_REFERENCE = True
+
+    def _save_to_state_dict(self, destination, prefix, keep_vars):


can we refactor these to utils and use the same copy of code instead of duplicating code?

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168

Looks good overall, had a few comments inline

terrychenism · 2022-02-15T18:31:54Z

@terrychenism has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Pull Request resolved: #72473 Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Imported from OSS Reviewed By: jerryzh168 Differential Revision: D34126542 fbshipit-source-id: 7da167695a1fd9c141059bce14cce4f0608b086c

github-actions · 2022-02-16T01:56:56Z

Hey @terrychenism.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

malfet · 2022-02-16T22:15:03Z

Reverting as it breaks MacOS test sanity, see https://hud.pytorch.org/commit/pytorch/pytorch/7a031ec17f5cfc052e618694d4bee28381a6051d

test_conv_1d (quantization.eager.test_quantize_eager_ptq.TestQuantizeEagerOps) ... ERROR (0.016s)

facebook-github-bot · 2022-02-16T22:24:23Z

This pull request has been reverted by e6fd28f. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D34126542](https://our.internmc.facebook.com/intern/diff/D34126542) [ghstack-poisoned]

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ec6a0dc Pull Request resolved: #72473

terrychenism · 2022-02-17T01:46:41Z

@terrychenism has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Pull Request resolved: pytorch/pytorch#72473 Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Imported from OSS Reviewed By: jerryzh168 Differential Revision: D34126542 fbshipit-source-id: 7da167695a1fd9c141059bce14cce4f0608b086c (cherry picked from commit dee22dcf483e5b7f057ff6038acb893a6b01c91e)

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D34292446](https://our.internmc.facebook.com/intern/diff/D34292446) [ghstack-poisoned]

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c9fce9e Pull Request resolved: #72473

Summary: Pull Request resolved: pytorch/pytorch#72473 Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Imported from OSS Reviewed By: jerryzh168 Differential Revision: D34126542 fbshipit-source-id: 7da167695a1fd9c141059bce14cce4f0608b086c (cherry picked from commit dee22dcf483e5b7f057ff6038acb893a6b01c91e)

[Qunat] Add ConvTranspose reference module

8580806

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

terrychenism requested review from albanD and jbschlosser as code owners February 7, 2022 22:55

pytorch-bot bot added the ciflow/default label Feb 7, 2022

facebook-github-bot added the cla signed label Feb 7, 2022

terrychenism requested review from jerryzh168 and vkuzo and removed request for albanD and jbschlosser February 7, 2022 22:56

Update on "[Qunat] Add ConvTranspose reference module"

3bb1263

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[Qunat] Add ConvTranspose reference module"

d313df8

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[Qunat] Add ConvTranspose reference module"

ac3288e

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[Qunat] Add ConvTranspose reference module"

76c01c5

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

vkuzo reviewed Feb 8, 2022

View reviewed changes

Update on "[Qunat] Add ConvTranspose reference module"

964931f

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 reviewed Feb 8, 2022

View reviewed changes

Update on "[Qunat] Add ConvTranspose reference module"

0c75aa7

Summary: Add ConvTranspose reference module Test Plan: python3 test/test_quantization.py TestQuantizeEagerOps.test_conv_transpose_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 approved these changes Feb 15, 2022

View reviewed changes

pytorchmergebot closed this in 7a031ec Feb 16, 2022

facebook-github-bot added the Reverted label Feb 16, 2022

terrychenism reopened this Feb 17, 2022

terrychenism changed the title ~~[Qunat] Add ConvTranspose reference module~~ [Quant] Add ConvTranspose reference module Feb 17, 2022

terrychenism closed this Feb 17, 2022

janeyx99 mentioned this pull request Feb 18, 2022

[Meta] CI Revert Tracker #66178

Closed

facebook-github-bot deleted the gh/terrychenism/15/head branch February 21, 2022 15:17

[Quant] Add ConvTranspose reference module #72473

[Quant] Add ConvTranspose reference module #72473

Uh oh!

Conversation

terrychenism commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Feb 7, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

Uh oh!

terrychenism commented Feb 7, 2022

Uh oh!

vkuzo Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

vkuzo Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

jerryzh168 Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

jerryzh168 Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

jerryzh168 Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

jerryzh168 Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

jerryzh168 left a comment

Choose a reason for hiding this comment

Uh oh!

terrychenism commented Feb 15, 2022

Uh oh!

github-actions bot commented Feb 16, 2022

Uh oh!

malfet commented Feb 16, 2022

Uh oh!

facebook-github-bot commented Feb 16, 2022

Uh oh!

terrychenism commented Feb 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

terrychenism commented Feb 7, 2022 •

edited

Loading

facebook-github-bot commented Feb 7, 2022 •

edited

Loading