[pytorch profiler] enable iteation tracking for kineto #72292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit dad2e5b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33825241 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33825241 |
briancoutinho
force-pushed
the
export-D33825241
branch
from
2b27e50 to
1901e47
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33825241 |
briancoutinho
force-pushed
the
export-D33825241
branch
from
1901e47 to
34fbed1
Compare
briancoutinho
force-pushed
the
export-D33825241
branch
from
34fbed1 to
6fe32a1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33825241 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33825241 |
briancoutinho
force-pushed
the
export-D33825241
branch
from
6fe32a1 to
80bfc95
Compare
Summary: Pull Request resolved: pytorch#72292 Integrates the libkineto step() method into pytorch profiler step() invocation. This enables Kineto to track the iteration count and trigger trace collection on iteration boundaries from outside the process. Test Plan: ## Test using pytorch profiler step() method Modified the resnet integration test to use pytorch profiler. Configure it to capture 3 iterations : ``` ACTIVITIES_COMPRESSION_ALGORITHM=GZIP ACTIVITIES_MANIFOLD_PATH=gpu_traces/tree/traces/dynocli/0/1643063194/127.0.0.1/ PROFILE_START_ITERATION=200 ACTIVITIES_WARMUP_ITERATIONS=1 ACTIVITIES_ITERATIONS=3 ``` Run dyno gputrace -gpuconf /tmp/kineto_pytorch.conf The output trace has iterations 202, 203, 204 :) One iteration is skipped due to warmup. (Also its one off due 0 vs 1 indexing) [Trace link](https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1643063194%2F127.0.0.1%2Flibkineto_activities_501743.json.gz&bucket=gpu_traces) {F695716262} Reviewed By: robieta Differential Revision: D33825241 fbshipit-source-id: e3f7781143370db3c551c82a6d10f5073aac6ebd
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33825241 |
briancoutinho
force-pushed
the
export-D33825241
branch
from
80bfc95 to
dad2e5b
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
Summary: Pull Request resolved: #72292 Integrates the libkineto step() method into pytorch profiler step() invocation. This enables Kineto to track the iteration count and trigger trace collection on iteration boundaries from outside the process. Test Plan: ## Test using pytorch profiler step() method Modified the resnet integration test to use pytorch profiler. Configure it to capture 3 iterations : ``` ACTIVITIES_COMPRESSION_ALGORITHM=GZIP ACTIVITIES_MANIFOLD_PATH=gpu_traces/tree/traces/dynocli/0/1643063194/127.0.0.1/ PROFILE_START_ITERATION=200 ACTIVITIES_WARMUP_ITERATIONS=1 ACTIVITIES_ITERATIONS=3 ``` Run dyno gputrace -gpuconf /tmp/kineto_pytorch.conf The output trace has iterations 202, 203, 204 :) One iteration is skipped due to warmup. (Also its one off due 0 vs 1 indexing) [Trace link](https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1643063194%2F127.0.0.1%2Flibkineto_activities_501743.json.gz&bucket=gpu_traces) {F695716262} Reviewed By: robieta Differential Revision: D33825241 fbshipit-source-id: 70983420cf47ebbac7b44bfb6494d314506302c5
Contributor
|
Hey @briancoutinho. |
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: #72292 Integrates the libkineto step() method into pytorch profiler step() invocation. This enables Kineto to track the iteration count and trigger trace collection on iteration boundaries from outside the process. Test Plan: ## Test using pytorch profiler step() method Modified the resnet integration test to use pytorch profiler. Configure it to capture 3 iterations : ``` ACTIVITIES_COMPRESSION_ALGORITHM=GZIP ACTIVITIES_MANIFOLD_PATH=gpu_traces/tree/traces/dynocli/0/1643063194/127.0.0.1/ PROFILE_START_ITERATION=200 ACTIVITIES_WARMUP_ITERATIONS=1 ACTIVITIES_ITERATIONS=3 ``` Run dyno gputrace -gpuconf /tmp/kineto_pytorch.conf The output trace has iterations 202, 203, 204 :) One iteration is skipped due to warmup. (Also its one off due 0 vs 1 indexing) [Trace link](https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1643063194%2F127.0.0.1%2Flibkineto_activities_501743.json.gz&bucket=gpu_traces) {F695716262} Reviewed By: robieta Differential Revision: D33825241 fbshipit-source-id: 70983420cf47ebbac7b44bfb6494d314506302c5 (cherry picked from commit 96c06ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Integrates the libkineto step() method into pytorch profiler step() invocation.
This enables Kineto to track the iteration count and trigger trace collection on iteration boundaries from outside the process.
Test Plan:
Test using pytorch profiler step() method
Modified the resnet integration test to use pytorch profiler.
Configure it to capture 3 iterations :
Run
dyno gputrace -gpuconf /tmp/kineto_pytorch.conf
The output trace has iterations 202, 203, 204 :) One iteration is skipped due to warmup. (Also its one off due 0 vs 1 indexing)
Trace link
{F695716262}
Reviewed By: robieta
Differential Revision: D33825241