Skip to content

[acc_ops] Move slice_tensor to consider single dim at a time #71883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jfix71 wants to merge 1 commit into from
Closed

[acc_ops] Move slice_tensor to consider single dim at a time #71883

jfix71 wants to merge 1 commit into from

Conversation

@jfix71
Copy link
Contributor

@jfix71 jfix71 commented Jan 26, 2022 •
edited
Loading

Summary:
Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455 (66939e3).

Test Plan: CI

Differential Revision: D33802222

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 26, 2022

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/jfix71/pytorch/blob/2260e7e7d588534aceb502e3ac54c0288886e87f/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
linux-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-manywheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk, ciflow/xla ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-bionic-rocm4.5-py3.7 ciflow/all, ciflow/linux, ciflow/rocm, ciflow/trunk 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 26, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e07c30b (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 26, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 26, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 27, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 27, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@jfix71 jfix71 changed the title [acc_ops] Fix slice_tensor retracing, and fix retrace coverage [acc_ops] Move slice_tensor to consider single dim at a time Jan 28, 2022
@jfix71 jfix71 mentioned this pull request Jan 28, 2022
Closed
jfix71 added a commit to jfix71/glow that referenced this pull request Jan 28, 2022
@jfix71 @facebook-github-bot
Move slice_tensor to consider single dim at a time (#71883)
60d67e0 
Summary:
Pull Request resolved: pytorch/pytorch#71883

Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455.

Differential Revision: D33802222

fbshipit-source-id: 7fe2138488cb8f61cce2a21c0775e0d1c3610f6f
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 28, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 28, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 28, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 28, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

jfix71 added a commit to jfix71/glow that referenced this pull request Jan 28, 2022
@jfix71 @facebook-github-bot
Move slice_tensor to consider single dim at a time (pytorch#5906)
8680c83 
Summary:
Pull Request resolved: pytorch#5906

Pull Request resolved: pytorch/pytorch#71883

Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455.

Reviewed By: wushirong

Differential Revision: D33802222

fbshipit-source-id: b095733a3fa70c4a98f3ab880a249e358aa1e5bf
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 28, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 28, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 29, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 31, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

@jfix71 @facebook-github-bot
[acc_ops] Move slice_tensor to consider single dim at a time (pytorch…
e07c30b 
…#5906)

Summary:
Pull Request resolved: pytorch/glow#5906

Pull Request resolved: pytorch#71883

Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455 (pytorch@66939e3).

Test Plan: CI

Reviewed By: wushirong

Differential Revision: D33802222

fbshipit-source-id: 6796d65ea79107c0fcc577b583601f7c2dd35db1
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 31, 2022

This pull request was exported from Phabricator. Differential Revision: D33802222

facebook-github-bot pushed a commit that referenced this pull request Jan 31, 2022
@jfix71 @facebook-github-bot
[acc_ops] Move slice_tensor to consider single dim at a time (#5906)
98fd23c 
Summary:
Pull Request resolved: pytorch/glow#5906

Pull Request resolved: #71883

Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455 (66939e3).

Test Plan: CI

Reviewed By: wushirong

Differential Revision: D33802222

fbshipit-source-id: 4e0e44ae4a4eb70b99d79f0cd582182031b87e25
pytorchmergebot pushed a commit that referenced this pull request Jan 31, 2022
@jfix71 @pytorchmergebot
[acc_ops] Move slice_tensor to consider single dim at a time (#5906)
184b78c 
Summary:
Pull Request resolved: pytorch/glow#5906

Pull Request resolved: #71883

Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455 (66939e3).

Test Plan: CI

Reviewed By: wushirong

Differential Revision: D33802222

fbshipit-source-id: 4e0e44ae4a4eb70b99d79f0cd582182031b87e25
(cherry picked from commit 98fd23c)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 3, 2022
@jfix71 @cyyever
[acc_ops] Move slice_tensor to consider single dim at a time (#5906)
87f2711 
Summary:
Pull Request resolved: pytorch/glow#5906

Pull Request resolved: pytorch/pytorch#71883

Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455 (pytorch/pytorch@66939e3).

Test Plan: CI

Reviewed By: wushirong

Differential Revision: D33802222

fbshipit-source-id: 4e0e44ae4a4eb70b99d79f0cd582182031b87e25
(cherry picked from commit 98fd23c)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 3, 2022
@jfix71 @cyyever
[acc_ops] Move slice_tensor to consider single dim at a time (#5906)
502567e 
Summary:
Pull Request resolved: pytorch/glow#5906

Pull Request resolved: pytorch/pytorch#71883

Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455 (pytorch/pytorch@66939e3).

Test Plan: CI

Reviewed By: wushirong

Differential Revision: D33802222

fbshipit-source-id: 4e0e44ae4a4eb70b99d79f0cd582182031b87e25
(cherry picked from commit 98fd23c)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 9, 2022
@jfix71 @cyyever
[acc_ops] Move slice_tensor to consider single dim at a time (#5906)
497c65c 
Summary:
Pull Request resolved: pytorch/glow#5906

Pull Request resolved: pytorch/pytorch#71883

Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455 (pytorch/pytorch@66939e3).

Test Plan: CI

Reviewed By: wushirong

Differential Revision: D33802222

fbshipit-source-id: 4e0e44ae4a4eb70b99d79f0cd582182031b87e25
(cherry picked from commit 98fd23c)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 9, 2022
@jfix71 @cyyever
[acc_ops] Move slice_tensor to consider single dim at a time (#5906)
99e3f06 
Summary:
Pull Request resolved: pytorch/glow#5906

Pull Request resolved: pytorch/pytorch#71883

Fixes slice_tensor retracing. Include fix for retrace coverage.

Missed in D33760455 (pytorch/pytorch@66939e3).

Test Plan: CI

Reviewed By: wushirong

Differential Revision: D33802222

fbshipit-source-id: 4e0e44ae4a4eb70b99d79f0cd582182031b87e25
(cherry picked from commit 98fd23c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed fb-exported module: fx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jfix71 @facebook-github-bot