[ONNX] ONNX Exporter logging #71342
Closed
[ONNX] ONNX Exporter logging #71342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit da7022b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
Collaborator
thiagocrepaldi
left a comment
thiagocrepaldi
left a comment
There was a problem hiding this comment.
Overall looks great. Just have made a comment on how to initialize/enabled/disable the log
thiagocrepaldi
added
the
onnx-needs-info
BowenBao
removed
the
onnx-needs-info
thiagocrepaldi
approved these changes
Feb 15, 2022
BowenBao
force-pushed
the
onnx_logger
branch
from
adc11eb to
68eb882
Compare
BowenBao
requested review from
IvanYashchuk,
atalman,
janeyx99,
jeffdaily,
jithunnair-amd,
lezcano,
nikitaved and
seemethere
as code owners
Collaborator
|
@BowenBao Will this be merged into pytorch:master directly or should we change it to pytorch:onnx_ms_1? |
Collaborator
Author
I'm planning to directly merge into master. |
BowenBao
force-pushed
the
onnx_logger
branch
from
3532c6c to
a64a27d
Compare
BowenBao
added
the
onnx-needs-import
Contributor
|
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
malfet
reviewed
Feb 24, 2022
BowenBao
force-pushed
the
onnx_logger
branch
from
1e94515 to
dd7c9fd
Compare
Contributor
|
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
@BowenBao what is procedure when a PR waiting to be imported conflicts with master? do we have to rebase it and ask for another import? |
Collaborator
Author
If the PR is not imported, you should rebase it. |
Update for mypy fix docs update api update docs on api change clang-tidy Fix node name printing address comments nit
BowenBao
force-pushed
the
onnx_logger
branch
from
dd7c9fd to
da7022b
Compare
Contributor
|
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Trying to land again |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
Summary: Add ONNX exporter logging facility. Supporting both C++/Python logging api. Logging can be turned on/off. Logging output stream can be either set to `stdout` or `stderr`. A few other changes: * When exception is raised in passes, the current IR graph being processed will be logged. * When exception is raised from `_jit_pass_onnx` (the pass that converts nodes from namespace `ATen` to `ONNX`), both ATen IR graph and ONNX IR graph under construction will be logged. * Exception message for ConstantFolding is truncated to avoid being too verbose. * Update the final printed IR graph with node name in ONNX ModelProto as node attribute. Torch IR Node does not have name. Adding this to printed IR graph helps debugging. Pull Request resolved: #71342 Reviewed By: msaroufim Differential Revision: D34433473 Pulled By: malfet fbshipit-source-id: 4b137dfd6a33eb681a5f2612f19aadf5dfe3d84a
Contributor
|
Hey @BowenBao. |
BowenBao
added
topic: improvements
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Add ONNX exporter logging facility. Supporting both C++/Python logging api. Logging can be turned on/off. Logging output stream can be either set to `stdout` or `stderr`. A few other changes: * When exception is raised in passes, the current IR graph being processed will be logged. * When exception is raised from `_jit_pass_onnx` (the pass that converts nodes from namespace `ATen` to `ONNX`), both ATen IR graph and ONNX IR graph under construction will be logged. * Exception message for ConstantFolding is truncated to avoid being too verbose. * Update the final printed IR graph with node name in ONNX ModelProto as node attribute. Torch IR Node does not have name. Adding this to printed IR graph helps debugging. Pull Request resolved: #71342 Reviewed By: msaroufim Differential Revision: D34433473 Pulled By: malfet fbshipit-source-id: 4b137dfd6a33eb681a5f2612f19aadf5dfe3d84a (cherry picked from commit 67a8ebe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ONNX exporter logging facility. Supporting both C++/Python logging api. Logging can be turned on/off. Logging output stream can be either set to
stdoutorstderr.A few other changes:
_jit_pass_onnx(the pass that converts nodes from namespaceATentoONNX), both ATen IR graph and ONNX IR graph under construction will be logged.