CPU Kernel: Use per-operator headers #71137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
peterbell10
requested review from
IvanYashchuk,
lezcano and
nikitaved
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c9d499b (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Jan 12, 2022
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 [ghstack-poisoned]
malfet
approved these changes
Feb 2, 2022
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 Differential Revision: [D33949900](https://our.internmc.facebook.com/intern/diff/D33949900) [ghstack-poisoned]
ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 Differential Revision: [D33949900](https://our.internmc.facebook.com/intern/diff/D33949900) [ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Feb 8, 2022
ghstack-source-id: 0ffdae0 Pull Request resolved: pytorch#71137
Collaborator
Author
|
@malfet any updates? |
ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 Differential Revision: [D33949900](https://our.internmc.facebook.com/intern/diff/D33949900) [ghstack-poisoned]
ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 Differential Revision: [D33949900](https://our.internmc.facebook.com/intern/diff/D33949900) [ghstack-poisoned]
Collaborator
Author
|
@malfet ping |
ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 Differential Revision: [D33949900](https://our.internmc.facebook.com/intern/diff/D33949900) [ghstack-poisoned]
ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 Differential Revision: [D33949900](https://our.internmc.facebook.com/intern/diff/D33949900) [ghstack-poisoned]
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
Summary: Pull Request resolved: #71137 ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33949900 Pulled By: malfet fbshipit-source-id: d76a53bfab9ea75391de060a2d85923339f93a7c
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#71137 ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33949900 Pulled By: malfet fbshipit-source-id: d76a53bfab9ea75391de060a2d85923339f93a7c (cherry picked from commit d3be6e4283bbc8d5c967c4634ea1a6b3386861ed)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#71137 ATen has a header dependency problem. Whenever an operator is added or modified, it changes `ATen/Functions.h` and `ATen/NativeFunctions.h` which in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds. See this note for more details: https://github.com/pytorch/pytorch/blob/3a03af2f505494582f1359254431f0c47fd88705/aten/src/ATen/templates/Functions.h#L20 Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D33949900 Pulled By: malfet fbshipit-source-id: d76a53bfab9ea75391de060a2d85923339f93a7c (cherry picked from commit d3be6e4283bbc8d5c967c4634ea1a6b3386861ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ATen has a header dependency problem. Whenever an operator is added or modified, it changes
ATen/Functions.handATen/NativeFunctions.hwhich in turn requires essentially every single file to be rebuilt. Per-operator headers allow files to only include the specific operators they use and so minimizes unnecessary rebuilds during incremental builds and improves cache hits in CI builds.See this note for more details:
pytorch/aten/src/ATen/templates/Functions.h
Line 20 in 3a03af2
Differential Revision: D33949900