Skip to content

clamp now has subgradient 1 at min and max #7049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssnl merged 3 commits into from
Apr 30, 2018
Merged

clamp now has subgradient 1 at min and max #7049

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94c60a6
subgradient 1 at min and max for clamp
ssnl Apr 27, 2018
50d4e69
clamp max and clamp min too
ssnl Apr 28, 2018
f15c421
add comment
ssnl Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tools/autograd/derivatives.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,17 @@
- name: ceil(Tensor self)
self: zeros_like(grad)

# For clamp, clamp_min, and clamp_max, gradient is not defined at the
# boundaries. But empirically it's helpful to be able to get gradient on min and
# max, so we return the subgradient 1 for these cases.
- name: clamp(Tensor self, Scalar min, Scalar max)
self: grad * (self > min).type_as(grad) * (self < max).type_as(grad)
self: grad * ((self >= min) * (self <= max)).type_as(grad)

- name: clamp_min(Tensor self, Scalar min)
self: grad * (self > min).type_as(grad)
self: grad * (self >= min).type_as(grad)

- name: clamp_max(Tensor self, Scalar max)
self: grad * (self < max).type_as(grad)
self: grad * (self <= max).type_as(grad)

- name: clone(Tensor self)
self: grad
Expand Down