Fixing LP-Pooling stability issues #6766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejoebstl
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ezyang
approved these changes
Apr 22, 2018
Contributor
|
@pytorchbot retest this please |
Contributor
Author
|
Before you merge, please make sure that this is really desired. The hack works well in practice (at least better than having NANs), but I'm not sure if other values (-1, +1) would be better. |
Contributor
|
CC @soumith |
Member
|
I think it would be good to add a test fornthis case as well. |
Contributor
Author
Contributor
|
i think this is reasonable. I've merged it. |
Jorghi12
pushed a commit
to wsttiger/pytorch
that referenced
this pull request
May 10, 2018
* Added ReLU unit to LP pooling, so the gradient does not become NAN if all inputs are zero. * Added workaround for odd p. Added a bit of doc. * Make the linter happy.
weiyangfb
pushed a commit
to weiyangfb/pytorch
that referenced
this pull request
Jun 11, 2018
* Added ReLU unit to LP pooling, so the gradient does not become NAN if all inputs are zero. * Added workaround for odd p. Added a bit of doc. * Make the linter happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradient of LP-Pooling is undefined when the sum of all inputs to the power of
pis zero. The current implementation will yield NAN in this case.I've added a ReLU unit to set the gradient to zero if the sum of all input elements to the power of
pis zero.This would fix issue #6765.