Export onnx protobuf bindings to python #6651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bddppq
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
apaszke
previously requested changes
Apr 17, 2018
Contributor
apaszke
left a comment
apaszke
left a comment
There was a problem hiding this comment.
Need an underscore in front of the module name. Then LGTM
torch/csrc/onnx/init.cpp
Outdated
| namespace torch { namespace onnx { | ||
| void initONNXBindings(PyObject* module) { | ||
| auto m = py::handle(module).cast<py::module>(); | ||
| auto onnx = m.def_submodule("onnx"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Apr 17, 2018
Jorghi12
pushed a commit
to wsttiger/pytorch
that referenced
this pull request
May 10, 2018
* Export onnx protobuf bindings to python * rename native onnx module to _onnx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to review comments in #6574