Codemod to update our codebase to 0.4 standard #6641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ssnl
force-pushed
the
dp_fn
branch
2 times, most recently
from
4f9ec78 to
528b4d7
Compare
ssnl
force-pushed
the
dp_fn
branch
2 times, most recently
from
563aa11 to
a242fda
Compare
Contributor
|
What are the particular codemods you did? |
ezyang
approved these changes
Apr 17, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
I spot checked a few codemods and they looked good. Merge when green, lest we merge conflict soon...
Collaborator
Author
|
@ezyang Thanks. I updated the description. |
Collaborator
Author
|
FYI the PyTorch CI build passes. onnx build fails with merge conflicts. I'll rebase and merge when onnx passes. |
ssnl
force-pushed
the
dp_fn
branch
2 times, most recently
from
c1ec064 to
7b3f730
Compare
Collaborator
Author
|
blocked by onnxbot/onnx-fb-universe#1621 |
Jorghi12
pushed a commit
to wsttiger/pytorch
that referenced
this pull request
May 10, 2018
* Codemod to update our codebase to 0.4 standard * Update some of the test scri[ts * remove Variable in test_clip_grad_value * fix _symbolic_override_wrapper_maker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VariabletoTensorin doc text and examplesVariabletoTensor, e.g.isinstanceVariableand onTenorsvariableTest scripts are not completely updated (too many)
Also addresses #6276