Fix some mistake usage of LinearFunction.backward(...) and a argument of gradcheck(...) in the documents #6587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sccbhxc
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
zou3519
requested changes
Apr 13, 2018
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
Thanks for the catch! It is intended that we're using ctx.saved_tensors instead of ctx.saved_variables.
| @staticmethod | ||
| def backward(ctx, grad_output): | ||
| # This is a pattern that is very convenient - at the top of backward | ||
| # unpack saved_tensors and initialize all gradients w.r.t. inputs to |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| # None. Thanks to the fact that additional trailing Nones are | ||
| # ignored, the return statement is simple even when the function has | ||
| # optional inputs. | ||
| input, weight, bias = ctx.saved_tensors |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Collaborator
|
@sccbhxc Thanks for your PR. This is good to merge once the minor nit is fixed. |
Contributor
|
#7725 fixes this, so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.