Support arbitrary number of batch dimensions in *FFT #6528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ssnl
force-pushed
the
fft_multidim_batch
branch
from
2ee44ab to
b0bd00b
Compare
zou3519
reviewed
Apr 11, 2018
| ss << "Expected an input tensor of floating types, but got input " | ||
| ss << "Expected an input tensor of floating types, but got input=" | ||
| << self.type() << self.sizes(); | ||
| throw std::runtime_error(ss.str()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
zou3519
approved these changes
Apr 12, 2018
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
lgtm. Is it ever useful to support broadcasting of these batch dimensions?
soumith
approved these changes
Apr 12, 2018
Collaborator
Author
|
Input is just a single tensor, so I don't think that broadcasting is involved here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6516 .