[pytorch] Fix signed random_ #6463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albanD
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ssnl
reviewed
Apr 10, 2018
Collaborator
ssnl
left a comment
ssnl
left a comment
There was a problem hiding this comment.
Thanks Alban! Can you move the cuda part of the test to test_cuda.py? They can call the same staticmethod on TestTorch. :)
Collaborator
Author
|
Done, |
ssnl
reviewed
Apr 10, 2018
| torch.cuda.nvtx.mark("bar") | ||
| torch.cuda.nvtx.range_pop() | ||
|
|
||
| def test_random_neg_values(self): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ssnl
approved these changes
Apr 10, 2018
Collaborator
ssnl
left a comment
ssnl
left a comment
There was a problem hiding this comment.
Good to merge once CI passes
soumith
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #6338 and tests