Skip to content

Enable resetting of batchnorm running moments and cumulative average #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
houseroad merged 1 commit into from
Apr 27, 2018
Merged

Enable resetting of batchnorm running moments and cumulative average #6445

houseroad merged 1 commit into from
Apr 27, 2018

Conversation

@jma127
Copy link
Contributor

@jma127 jma127 commented Apr 9, 2018

Duplicate of #5766

colesbury
colesbury reviewed Apr 9, 2018
View reviewed changes
torch/nn/modules/batchnorm.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@jma127
Copy link
Contributor Author

jma127 commented Apr 9, 2018

cc @soumith

@bddppq
Copy link
Contributor

bddppq commented Apr 10, 2018

@onnxbot test this please

@onnxbot-worker-2 onnxbot-worker-2 mentioned this pull request Apr 10, 2018
Closed
ezyang
ezyang requested changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge of this until BC-breakage is resolved

@ssnl
Copy link
Collaborator

ssnl commented Apr 16, 2018

fyi, I'm working on load_state_dict to solve the issue.

@ssnl ssnl mentioned this pull request Apr 16, 2018
Merged
@jma127
Copy link
Contributor Author

jma127 commented Apr 16, 2018

Thanks so much -- would be great to have it in time for the next release :)

@jma127
Copy link
Contributor Author

jma127 commented Apr 26, 2018

@pytorchbot retest this please

1 similar comment
@jma127
Copy link
Contributor Author

jma127 commented Apr 26, 2018

@pytorchbot retest this please

@jma127
Copy link
Contributor Author

jma127 commented Apr 26, 2018

Can someone help me out with this onnx check?

@soumith
Copy link
Contributor

soumith commented Apr 26, 2018

@ssnl please have a look

@soumith soumith closed this Apr 26, 2018
@soumith soumith reopened this Apr 26, 2018
@soumith
Copy link
Contributor

soumith commented Apr 26, 2018

(closed by mistake)

ssnl
ssnl reviewed Apr 26, 2018
View reviewed changes
Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the new buffer should be in onnx export or not. If it should be, then updating the onnx expected output would be an easy fix.

torch/nn/modules/batchnorm.py Outdated

This comment was marked as off-topic.

Sign in to view

torch/nn/modules/batchnorm.py Outdated

This comment was marked as off-topic.

Sign in to view

torch/nn/modules/batchnorm.py Outdated

This comment was marked as off-topic.

Sign in to view

@ssnl
Copy link
Collaborator

ssnl commented Apr 26, 2018

The TestCaffe2Backend.test_resnet fail is at least easy to try locally. Could you see if it works?

@jma127
Copy link
Contributor Author

jma127 commented Apr 26, 2018

comments addressed. I'm not sure what the TestCaffe2Backend test is, as grepping for that string returns nothing.

@dzhulgakov
Copy link
Collaborator

dzhulgakov commented Apr 26, 2018

@onnxbot retest this please

@houseroad
Copy link
Member

houseroad commented Apr 27, 2018

@pytorchbot test this please

@houseroad houseroad mentioned this pull request Apr 27, 2018
Merged
@houseroad
Copy link
Member

houseroad commented Apr 27, 2018

@ezyang merge this one with onnxbot/onnx-fb-universe#1792 together

@houseroad houseroad merged commit 76d3c30 into pytorch:master Apr 27, 2018
@jma127
Copy link
Contributor Author

jma127 commented Apr 27, 2018

Woohoo! Thanks to all!

Jorghi12 pushed a commit to wsttiger/pytorch that referenced this pull request May 10, 2018
@jma127 @Jorghi12
Enable resetting of batchnorm running moments and cumulative ("simple…
e6bc6bd 
…") moving average (pytorch#6445)
weiyangfb pushed a commit to weiyangfb/pytorch that referenced this pull request Jun 11, 2018
@jma127 @weiyangfb
Enable resetting of batchnorm running moments and cumulative ("simple…
573fb2d 
…") moving average (pytorch#6445)
@ssnl ssnl mentioned this pull request Jun 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury left review comments

@ssnl ssnl ssnl left review comments

@ezyang ezyang ezyang approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jma127 @bddppq @ssnl @soumith @dzhulgakov @houseroad @ezyang @colesbury