bottleneck supports better user-provided arguments #6425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pytorch#6312. Changed bottleneck's arg parser to user argparse.REMAINDER. This lets the user specify args as `python -m torch.utils.bottleneck script.py [args]` (previously, a -- was needed after `bottleneck` and before `script.py`).
zou3519
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
soumith
approved these changes
Apr 9, 2018
fmassa
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6312.
Changed bottleneck's arg parser to user argparse.REMAINDER. This lets
the user specify args as
python -m torch.utils.bottleneck script.py [args](previously, a -- was needed afterbottleneckand beforescript.py).cc @fmassa
Test Plan
Unit test in the bottleneck test suite. The test script errors out if any of the arguments are not provided.