[ready] Implement log2 and log10 in PyTorch #6272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
reviewed
Apr 4, 2018
| virtual Tensor log2(const Tensor & self) const; | ||
| virtual Tensor & lgamma_out(Tensor & result, const Tensor & self) const; | ||
| virtual Tensor lgamma(const Tensor & self) const; | ||
| virtual Tensor & lgamma_(Tensor & self) const; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
vishwakftw
requested review from
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ezyang
approved these changes
Apr 4, 2018
apaszke
approved these changes
Apr 4, 2018
Contributor
|
Windows failure is legit. |
Contributor
Author
|
The Windows build has been fixed. The only test failing is |
vishwakftw
changed the title
soumith
pushed a commit
that referenced
this pull request
Apr 5, 2018
…error" (#6322) * Revert "Add __constants__ to Script modules (#6092)" This reverts commit 5ab30ee. * Revert "[ready] Implement log2 and log10 in PyTorch (#6272)" This reverts commit 0aa3578. * Revert "Use reshape({-1}) (#6281)" This reverts commit 8ae67a4. * Revert "Move instruction set specific code to anonymous namespace (#6314)" This reverts commit 6953c1b. * Revert "[auto] Update onnx to 54be8fa - Use cmake3 if it's available (#718) onnx/onnx@54be8fa" This reverts commit d33ec12. * Revert "default build with MKL for desktop (#6266)" This reverts commit 5dcf707. * Revert "Increase # of runs for CPU perf test, and increase margin of error (#6302)" This reverts commit 9d1a660.
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
This reverts commit 0aa3578.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes feature request #6233 .
Tests have been added as well.
cc: @apaszke @soumith