Skip to content

Add arg checks in torch.utils.data.Sampler classes #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ezyang merged 2 commits into from
Apr 5, 2018
Merged

Add arg checks in torch.utils.data.Sampler classes #6249

ezyang merged 2 commits into from
Apr 5, 2018

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Apr 3, 2018

Fixes #6168

apaszke
apaszke reviewed Apr 4, 2018
View reviewed changes
torch/utils/data/sampler.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@onnxbot-worker-3 onnxbot-worker-3 mentioned this pull request Apr 4, 2018
Closed
@ezyang ezyang merged commit efc91d8 into pytorch:master Apr 5, 2018
@ssnl ssnl deleted the dlint branch April 5, 2018 03:51
@ssnl ssnl mentioned this pull request May 13, 2020
Closed
facebook-github-bot pushed a commit that referenced this pull request May 14, 2020
@ssnl @facebook-github-bot
Relax sampler check in BatchSampler (#38403)
b5868b2 
Summary:
Since the check was added in #6249, one can not pass an iterable as a sampler to the data loader anymore, which was a very handy feature (e.g., #1337). I think the check should be removed for two-fold reasons:
1. It is too strict. There is no reason that it should not be a general iterable.
2. It is inconsistent. In `DataLoader` (the main place where people use samplers), you can pass a general iterable as `batch_sampler` but not `sampler` due to this check.
Pull Request resolved: #38403

Differential Revision: D21555958

Pulled By: soumith

fbshipit-source-id: c7267bb99a31edd8f2750689205d6edc5dab5cff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmassa fmassa fmassa left review comments

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@zdevito zdevito Awaiting requested review from zdevito

+2 more reviewers

@apaszke apaszke apaszke left review comments

@soumith soumith soumith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataLoader loads whole dataset when it got non-int batch_size

5 participants

@ssnl @soumith @apaszke @fmassa @ezyang