Skip to content

Fix SGD lr check failing on default value #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 1 commit into from
Apr 4, 2018
Merged

Fix SGD lr check failing on default value #6244

soumith merged 1 commit into from
Apr 4, 2018

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Apr 3, 2018

Following up #6000

soumith
soumith reviewed Apr 4, 2018
View reviewed changes
torch/optim/sgd.py
def __init__(self, params, lr=required, momentum=0, dampening=0,
weight_decay=0, nesterov=False):
if not 0.0 <= lr:
if lr is not required and lr < 0.0:

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@soumith soumith merged commit a288053 into pytorch:master Apr 4, 2018
@ssnl ssnl deleted the sgd_lr branch April 4, 2018 01:30
@fmassa
Copy link
Member

fmassa commented Apr 4, 2018

Should this fix be applied to all optimizers?

@ssnl
Copy link
Collaborator Author

ssnl commented Apr 4, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@soumith soumith soumith left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ssnl @fmassa @soumith @ezyang