Skip to content

Support export torch.max(input, dim) and torch.min(input, dim) to ONNX #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ezyang merged 2 commits into from
Apr 3, 2018
Merged

Support export torch.max(input, dim) and torch.min(input, dim) to ONNX #6220

ezyang merged 2 commits into from
Apr 3, 2018

Conversation

@bddppq
Copy link
Contributor

@bddppq bddppq commented Apr 3, 2018

ezyang
ezyang reviewed Apr 3, 2018
View reviewed changes
torch/onnx/symbolic.py Outdated
keepdim_i=keepdim,
outputs=2)
else:
return g.op("Max", self, args[0])

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Apr 3, 2018
View reviewed changes
torch/onnx/symbolic.py
def min(g, self, other):
return g.op("Min", self, other)
# torch.max (same for torch.min) actually has two interfaces smashed together:
# torch.max(x, dim, keepdim) and torch.max(x, y)

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@ezyang ezyang merged commit 40096c9 into pytorch:master Apr 3, 2018
@ezyang ezyang mentioned this pull request Apr 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang left review comments

@colesbury colesbury colesbury left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bddppq @ezyang @colesbury